src/factory.cc - Issue 2889863002: Allow embedder to set promise internal field count

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 2889863002: Allow embedder to set promise internal field count (Closed)

Patch Set: Initialize external fields for promises constructed through factory Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index 3948eec3a722461b50bfdc241322fedb837f6060..7f2eae35ddd4cbc59dc307059e78b5bf65bd0a1a 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -927,6 +927,9 @@ Handle<JSPromise> Factory::NewJSPromise() {

Handle<JSPromise> promise = Handle<JSPromise>::cast(promise_obj);

promise->set_status(v8::Promise::kPending);

promise->set_flags(0);

+ for (int i = 0; i < v8::Promise::kEmbedderFieldCount; i++) {

+ promise->SetEmbedderField(i, Smi::kZero);

+ }

isolate()->RunPromiseHook(PromiseHookType::kInit, promise, undefined_value());

return promise;