third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js - Issue 2889853002: [DevTools] breakpoint manager should be ready for location from different model

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

Issue 2889853002: [DevTools] breakpoint manager should be ready for location from different model (Closed)

Patch Set: rebased Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoints-in-anonymous-script-with-two-targets-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js b/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

index 2883d3756ec26e19acd98f51eef3269f20270114..0098240bced049451707d95b1d4f2025828b99ee 100644

--- a/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

+++ b/third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

@@ -816,6 +816,8 @@ Bindings.BreakpointManager.ModelBreakpoint = class {

var debuggerLocation = uiSourceCode &&

Bindings.debuggerWorkspaceBinding.uiLocationToRawLocation(uiSourceCode, lineNumber, columnNumber);

+ if (debuggerLocation && debuggerLocation.debuggerModel !== this._debuggerModel)

+ debuggerLocation = null;

var newState;

if (this._breakpoint._isRemoved || !this._breakpoint.enabled() || this._scriptDiverged()) {

newState = null;