Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

Issue 2889853002: [DevTools] breakpoint manager should be ready for location from different model (Closed)
Patch Set: rebased Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 798 matching lines...) Expand 10 before | Expand all | Expand 10 after
809 return; 809 return;
810 } 810 }
811 811
812 var uiSourceCode = this._breakpoint.uiSourceCode(); 812 var uiSourceCode = this._breakpoint.uiSourceCode();
813 var lineNumber = this._breakpoint._lineNumber; 813 var lineNumber = this._breakpoint._lineNumber;
814 var columnNumber = this._breakpoint._columnNumber; 814 var columnNumber = this._breakpoint._columnNumber;
815 var condition = this._breakpoint.condition(); 815 var condition = this._breakpoint.condition();
816 816
817 var debuggerLocation = uiSourceCode && 817 var debuggerLocation = uiSourceCode &&
818 Bindings.debuggerWorkspaceBinding.uiLocationToRawLocation(uiSourceCode, lineNumber, columnNumber); 818 Bindings.debuggerWorkspaceBinding.uiLocationToRawLocation(uiSourceCode, lineNumber, columnNumber);
819 if (debuggerLocation && debuggerLocation.debuggerModel !== this._debuggerMod el)
820 debuggerLocation = null;
819 var newState; 821 var newState;
820 if (this._breakpoint._isRemoved || !this._breakpoint.enabled() || this._scri ptDiverged()) { 822 if (this._breakpoint._isRemoved || !this._breakpoint.enabled() || this._scri ptDiverged()) {
821 newState = null; 823 newState = null;
822 } else if (debuggerLocation) { 824 } else if (debuggerLocation) {
823 var script = debuggerLocation.script(); 825 var script = debuggerLocation.script();
824 if (script.sourceURL) { 826 if (script.sourceURL) {
825 newState = new Bindings.BreakpointManager.Breakpoint.State( 827 newState = new Bindings.BreakpointManager.Breakpoint.State(
826 script.sourceURL, null, debuggerLocation.lineNumber, debuggerLocatio n.columnNumber, condition); 828 script.sourceURL, null, debuggerLocation.lineNumber, debuggerLocatio n.columnNumber, condition);
827 } else { 829 } else {
828 newState = new Bindings.BreakpointManager.Breakpoint.State( 830 newState = new Bindings.BreakpointManager.Breakpoint.State(
(...skipping 257 matching lines...) Expand 10 before | Expand all | Expand 10 after
1086 this.url = breakpoint._url; 1088 this.url = breakpoint._url;
1087 this.lineNumber = breakpoint.lineNumber(); 1089 this.lineNumber = breakpoint.lineNumber();
1088 this.columnNumber = breakpoint.columnNumber(); 1090 this.columnNumber = breakpoint.columnNumber();
1089 this.condition = breakpoint.condition(); 1091 this.condition = breakpoint.condition();
1090 this.enabled = breakpoint.enabled(); 1092 this.enabled = breakpoint.enabled();
1091 } 1093 }
1092 }; 1094 };
1093 1095
1094 /** @type {!Bindings.BreakpointManager} */ 1096 /** @type {!Bindings.BreakpointManager} */
1095 Bindings.breakpointManager; 1097 Bindings.breakpointManager;
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoints-in-anonymous-script-with-two-targets-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698