Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Unified Diff: third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js

Issue 2889833003: DevTools: Show badges instead of products in ConsoleContextSelector (Closed)
Patch Set: Don't use container Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/console/consoleContextSelector.css ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js
diff --git a/third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js b/third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js
index 133d8dff23c3ea4deb40f433c8d4cf438ed092ae..31f719cf4e0d0d8e0a0305abd8df8a5501cf38f0 100644
--- a/third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js
+++ b/third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js
@@ -35,9 +35,9 @@ ProductRegistry.BadgePool = class {
* @return {!Element}
*/
_badgeForFrameOrUrl(urlResolver) {
- var element = createElement('span');
+ var element = createElementWithClass('span', 'hidden');
var root = UI.createShadowRootWithCoreStyles(element, 'product_registry/badge.css');
- var badgeElement = root.createChild('span', 'product-registry-badge monospace hidden');
+ var badgeElement = root.createChild('span', 'product-registry-badge monospace');
badgeElement.setAttribute('data-initial', ' ');
badgeElement.title = '';
badgeElement.addEventListener('mousedown', event => event.consume());
@@ -98,14 +98,14 @@ ProductRegistry.BadgePool = class {
badgeElement.setAttribute('data-initial', label.substring(0, 2).toUpperCase());
badgeElement.title = entryName;
badgeElement.style.backgroundColor = ProductRegistry.BadgePool.colorForEntryName(entryName);
- badgeElement.classList.toggle('hidden', !this._setting.get());
+ badgeElement.parentNodeOrShadowHost().parentNodeOrShadowHost().classList.toggle('hidden', !this._setting.get());
}
_settingUpdated() {
var enabled = this._setting.get();
if (!enabled) {
for (var badgeElement of this._badgeElements.keys())
- badgeElement.classList.add('hidden');
+ badgeElement.parentNodeOrShadowHost().parentNodeOrShadowHost().classList.add('hidden');
return;
}
for (var badgeElement of this._badgeElements.keys())
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/console/consoleContextSelector.css ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698