Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: ui/native_theme/fallback_theme.cc

Issue 288983010: fix text color of BlueButton on GTK-theme-mode Linux Aura. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: themify colors instead Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/native_theme/fallback_theme.cc
diff --git a/ui/native_theme/fallback_theme.cc b/ui/native_theme/fallback_theme.cc
index d995d71c69af5a1946c54ff702bb6b946ed595da..c59ef7de213dd2e672951eb02162d10eb9629b79 100644
--- a/ui/native_theme/fallback_theme.cc
+++ b/ui/native_theme/fallback_theme.cc
@@ -38,6 +38,10 @@ SkColor FallbackTheme::GetSystemColor(ColorId color_id) const {
static const SkColor kButtonHoverColor = kButtonEnabledColor;
static const SkColor kButtonHoverBackgroundColor =
SkColorSetRGB(0xEA, 0xEA, 0xEA);
+ static const SkColor kCallToActionButtonEnabledColor = SK_ColorWHITE;
msw 2014/06/02 21:06:20 nit: one const or inlined values would suffice for
Evan Stade 2014/06/02 22:18:14 this follows the precedent set by the rest of this
+ static const SkColor kCallToActionButtonDisabledColor = SK_ColorWHITE;
+ static const SkColor kCallToActionButtonHighlightColor = SK_ColorWHITE;
+ static const SkColor kCallToActionButtonHoverColor = SK_ColorWHITE;
// MenuItem:
static const SkColor kEnabledMenuItemForegroundColor = kButtonEnabledColor;
static const SkColor kDisabledMenuItemForegroundColor = kButtonDisabledColor;
@@ -142,6 +146,14 @@ SkColor FallbackTheme::GetSystemColor(ColorId color_id) const {
return kButtonHoverColor;
case kColorId_ButtonHoverBackgroundColor:
return kButtonHoverBackgroundColor;
+ case kColorId_CallToActionButtonEnabledColor:
+ return kCallToActionButtonEnabledColor;
+ case kColorId_CallToActionButtonDisabledColor:
+ return kCallToActionButtonDisabledColor;
+ case kColorId_CallToActionButtonHighlightColor:
+ return kCallToActionButtonHighlightColor;
+ case kColorId_CallToActionButtonHoverColor:
+ return kCallToActionButtonHoverColor;
// MenuItem
case kColorId_EnabledMenuItemForegroundColor:

Powered by Google App Engine
This is Rietveld 408576698