fix text color of BlueButton on GTK-theme-mode Linux Aura.

ui/views/controls/button/blue_button.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/button/blue_button.h"
 
 #include "grit/ui_resources.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/sys_color_change_listener.h"
 #include "ui/views/controls/button/label_button_border.h"
 
 namespace {
 
-// Default text and shadow colors for the blue button.
-const SkColor kBlueButtonTextColor = SK_ColorWHITE;
+// Default shadow color for the blue button.
 const SkColor kBlueButtonShadowColor = SkColorSetRGB(0x53, 0x8C, 0xEA);
 
 }  // namespace
 
 namespace views {
 
 // static
 const char BlueButton::kViewClassName[] = "views/BlueButton";
 
 BlueButton::BlueButton(ButtonListener* listener, const base::string16& text)
     : LabelButton(listener, text) {
   // Inherit STYLE_BUTTON insets, minimum size, alignment, etc.
   SetStyle(STYLE_BUTTON);
   UpdateThemedBorder();

[msw, 2014/06/03 02:10:10]

If we want these buttons to be blue, can't we just make BlueButton use the
normal Views border, and not apply the GTK-style border in
LabelButton::UpdateThemedBorder? Later, if we want to implement blue-tinted (or
highlighted) gtk-styled buttons, we can implement that? So, for now all you
really have to do is set |border_is_themed_border_| to false before this call,
or call SetBorder(CreateDefaultBorder().PassAs<Border>()) instead here to
essentially do the same thing.

 }
 
 BlueButton::~BlueButton() {}
 
 void BlueButton::ResetColorsFromNativeTheme() {
   LabelButton::ResetColorsFromNativeTheme();
   if (!gfx::IsInvertedColorScheme()) {
-    for (size_t state = STATE_NORMAL; state < STATE_COUNT; ++state)
-      SetTextColor(static_cast<ButtonState>(state), kBlueButtonTextColor);
+    SetTextColor(STATE_NORMAL, GetNativeTheme()->
+        GetSystemColor(
+            ui::NativeTheme::kColorId_CallToActionButtonEnabledColor));
+    SetTextColor(STATE_HOVERED, GetNativeTheme()->
+        GetSystemColor(
+            ui::NativeTheme::kColorId_CallToActionButtonHoverColor));
+    SetTextColor(STATE_PRESSED, GetNativeTheme()->
+        GetSystemColor(
+            ui::NativeTheme::kColorId_CallToActionButtonHighlightColor));
+    SetTextColor(STATE_DISABLED, GetNativeTheme()->
+        GetSystemColor(
+            ui::NativeTheme::kColorId_CallToActionButtonDisabledColor));
+
+    // TODO(estade): this is not great on system themes.

[msw, 2014/06/02 21:06:20]

Perhaps we could use a partially transparent version of the text color? That's
probably how the original shadow color was calculated (expecting white on blue).

[Evan Stade, 2014/06/02 22:18:14]

I'd be inclined to have no shadow on gtk system themes (fully transparent),
while leaving this color as the default in fallback theme. But exploring all the
options is a TODO.

     label()->SetShadowColors(kBlueButtonShadowColor, kBlueButtonShadowColor);
     label()->SetShadowOffset(0, 1);
   }
 }
 
 const char* BlueButton::GetClassName() const {
   return BlueButton::kViewClassName;
 }
 
 scoped_ptr<LabelButtonBorder> BlueButton::CreateDefaultBorder() const {
@@ skipping 14 matching lines @@
   button_border->SetPainter(true, STATE_HOVERED, Painter::CreateImagePainter(
       *rb.GetImageSkiaNamed(IDR_BLUE_BUTTON_FOCUSED_HOVER), insets));
   button_border->SetPainter(true, STATE_PRESSED, Painter::CreateImagePainter(
       *rb.GetImageSkiaNamed(IDR_BLUE_BUTTON_FOCUSED_PRESSED), insets));
   button_border->SetPainter(true, STATE_DISABLED, Painter::CreateImagePainter(
       *rb.GetImageSkiaNamed(IDR_BLUE_BUTTON_DISABLED), insets));
   return button_border.Pass();
 }
 
 }  // namespace views