Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2132)

Unified Diff: chrome/browser/about_flags.cc

Issue 2889823002: [omnibox] Added 'OmniboxTailSuggestions' flag (Closed)
Patch Set: Added histogram enumeration Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | chrome/browser/flag_descriptions.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index dd8a2e27bb8ec63fa83f773cc4cfc866f07e4d9f..4abdb686a480e6fd5456d806e072c115cb7769a5 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -2814,6 +2814,9 @@ const FeatureEntry kFeatureEntries[] = {
flag_descriptions::kOmniboxEntitySuggestionsName,
flag_descriptions::kOmniboxEntitySuggestionsDescription, kOsDesktop,
FEATURE_VALUE_TYPE(omnibox::kOmniboxEntitySuggestions)},
+ {"omnibox-tail-suggestions", flag_descriptions::kOmniboxTailSuggestionsName,
Mark P 2017/05/31 23:17:13 side comment: putting this here is fine with me, t
Kevin Bailey 2017/06/01 14:32:42 I would prefer putting it here, both for locality
Mark P 2017/06/01 16:23:58 Acknowledged.
+ flag_descriptions::kOmniboxTailSuggestionsDescription, kOsDesktop,
+ FEATURE_VALUE_TYPE(omnibox::kOmniboxTailSuggestions)},
{"enable-new-app-menu-icon", flag_descriptions::kEnableNewAppMenuIconName,
flag_descriptions::kEnableNewAppMenuIconDescription, kOsDesktop,
SINGLE_VALUE_TYPE(switches::kEnableNewAppMenuIcon)},
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | chrome/browser/flag_descriptions.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698