[omnibox] Added 'OmniboxTailSuggestions' flag

chrome/browser/about_flags.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/about_flags.h"
 
 #include <iterator>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 2796 matching lines @@
     {"new-omnibox-answer-types", flag_descriptions::kNewOmniboxAnswerTypesName,
      flag_descriptions::kNewOmniboxAnswerTypesDescription, kOsAll,
      FEATURE_VALUE_TYPE(omnibox::kNewOmniboxAnswerTypes)},
 
 #if defined(OS_CHROMEOS) || defined(OS_LINUX) || defined(OS_MACOSX) || \
     defined(OS_WIN)
     {"omnibox-entity-suggestions",
      flag_descriptions::kOmniboxEntitySuggestionsName,
      flag_descriptions::kOmniboxEntitySuggestionsDescription, kOsDesktop,
      FEATURE_VALUE_TYPE(omnibox::kOmniboxEntitySuggestions)},
+    {"omnibox-tail-suggestions", flag_descriptions::kOmniboxTailSuggestionsName,
+     flag_descriptions::kOmniboxTailSuggestionsDescription, kOsDesktop,

[Mark P, 2017/06/01 17:29:50]

drive-by: the tail suggest deck proposes enabling tail suggest for desktop and
iOS, yet this flag only does desktop.  Which one is wrong?

[Kevin Bailey, 2017/06/01 17:45:54]

While the desktop is capable of receiving and handling tail suggestions, my
understanding is that iOS is not. However we would like to add this support. So
as far as this CL is concerned, the answer is more like "not yet" than "never
and the doc is wrong."

[Justin Donnelly, 2017/06/02 14:21:42]

I've added a comment to the doc mentioning that the iOS implementation will
follow in the subsequent milestone.

+     FEATURE_VALUE_TYPE(omnibox::kOmniboxTailSuggestions)},
     {"enable-new-app-menu-icon", flag_descriptions::kEnableNewAppMenuIconName,
      flag_descriptions::kEnableNewAppMenuIconDescription, kOsDesktop,
      SINGLE_VALUE_TYPE(switches::kEnableNewAppMenuIcon)},
 #endif  // defined(OS_CHROMEOS) || defined(OS_LINUX) || defined(OS_MACOSX) ||
         // defined(OS_WIN)
 
 #if defined(OS_ANDROID)
     {"enable-custom-feedback-ui",
      flag_descriptions::kEnableCustomFeedbackUiName,
      flag_descriptions::kEnableCustomFeedbackUiDescription, kOsAndroid,
@@ skipping 431 matching lines @@
 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
 
 const FeatureEntry* GetFeatureEntries(size_t* count) {
   *count = arraysize(kFeatureEntries);
   return kFeatureEntries;
 }
 
 }  // namespace testing
 
 }  // namespace about_flags