Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 2889783002: [ES6 modules] FetchDescendants: skip fetch algorithm for descendants that are already ready

Created:
3 years, 7 months ago by kouhei (in TOK)
Modified:
3 years, 5 months ago
Reviewers:
hiroshige, module-dev, domenic, neis
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ES6 modules] FetchDescendants: skip fetch algorithm for descendants that are already ready Before this CL, we triggered #internal-module-graph-fetch-procedure for descendants which we already had its entry in the module map. This CL skips issuing #internal-module-graph-fetch-procedure for those descendants which we could find its "instantiated" module script entry on module map. This speeds up module tree fetch performance by reducing number of asynchronous tasks which has non-trivial overhead. This CL avoids the ModuleTreeLinker to wait on the asynchronous completion calls which will just complete immediately for "instantiated" module script tree. BUG=594639, 722728, 740874

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinker.cpp View 1 chunk +14 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (7 generated)
kouhei (in TOK)
3 years, 7 months ago (2017-05-16 20:40:55 UTC) #4

          

Powered by Google App Engine
This is Rietveld 408576698