third_party/WebKit/LayoutTests/editing/selection/mouse/click-user-select-none-loose-input-focus.html - Issue 2889763003: Accept text input only if selection has focus.

Side by Side Diff: third_party/WebKit/LayoutTests/editing/selection/mouse/click-user-select-none-loose-input-focus.html

Issue 2889763003: Accept text input only if selection has focus. (Closed)

Patch Set: update Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <script src="../../../resources/testharness.js"></script>
	yosin_UTC9 2017/05/17 10:17:58 nit: Please add <!doctype html> nit: Please add <!doctype html> yoichio 2017/05/18 09:31:49 Done. Show quoted text On 2017/05/17 10:17:58, yosin_UTC9 wrote: > nit: Please add <!doctype html> Done.
	2 <script src="../../../resources/testharnessreport.js"></script>

	3 <div id="outer" style="background: orange; padding: 50px; user-select: none" tab index="-1">

	4 <input id="input" value="foo" autofocus>

	5 </div>

	6 <script>

	7 var test = async_test();

	8

	9 var outer_isClicked = false;
	yosin_UTC9 2017/05/17 10:15:39 nit: %s/outer_isClicked/outerIsClicked/ nit: %s/outer_isClicked/outerIsClicked/ yoichio 2017/05/18 09:31:49 Acknowledged. Show quoted text On 2017/05/17 10:15:39, yosin_UTC9 wrote: > nit: %s/outer_isClicked/outerIsClicked/ Acknowledged.
	10 outer.onclick = function() { outer_isClicked = true;};

	11 var step2 = function() {

	12 test.step(function(){

	13 assert_true(outer_isClicked, 'outer div is clicked');
	yosin_UTC9 2017/05/17 10:15:39 Please add assert_exists(window, 'eventSender', ' Please add assert_exists(window, 'eventSender', 'This test requires eventSender.'); yoichio 2017/05/18 09:31:49 Done. Show quoted text On 2017/05/17 10:15:39, yosin_UTC9 wrote: > Please add > > assert_exists(window, 'eventSender', 'This test requires eventSender.'); Done.
	14 assert_equals(document.activeElement, outer, 'outer is focued');

	15 eventSender.keyDown('a');

	16 assert_equals(input.value, "foo", '');
	yosin_UTC9 2017/05/17 10:15:39 nit: s/"/'/ nit: s/"/'/ yoichio 2017/05/18 09:31:49 Done. Show quoted text On 2017/05/17 10:15:39, yosin_UTC9 wrote: > nit: s/"/'/ Done.
	17 test.done();

	18 });

	19 };

	20

	21 input.onfocus = function() {

	22 var pointerActions =

	23 [{source: "mouse",
	yosin_UTC9 2017/05/17 10:15:39 nit: s/"/'/ nit: s/"/'/ yoichio 2017/05/18 09:31:49 Done. Show quoted text On 2017/05/17 10:15:39, yosin_UTC9 wrote: > nit: s/"/'/ Done.
	24 actions: [

	25 { name: "pointerDown", x: 20, y: 20, button:'left' },
	yosin_UTC9 2017/05/17 10:15:39 nit: s/"/'/ nit: s/"/'/ Xiaocheng 2017/05/17 19:29:25 nit: For readability, please add a comment that th Show quoted text On 2017/05/17 at 10:15:39, yosin_UTC9 wrote: > nit: s/"/'/ nit: For readability, please add a comment that this is a mouse click in the padding of \|outer\|. yoichio 2017/05/18 09:31:48 Done. Show quoted text On 2017/05/17 10:15:39, yosin_UTC9 wrote: > nit: s/"/'/ Done. yoichio 2017/05/18 09:31:49 Done. Show quoted text On 2017/05/17 19:29:25, Xiaocheng wrote: > On 2017/05/17 at 10:15:39, yosin_UTC9 wrote: > > nit: s/"/'/ > > nit: For readability, please add a comment that this is a mouse click in the > padding of \|outer\|. Done.
	26 { name: "pointerUp", button:'left' },]}];
	yosin_UTC9 2017/05/17 10:15:39 nit: s/"/'/ nit: s/"/'/ yoichio 2017/05/18 09:31:49 Done. Show quoted text On 2017/05/17 10:15:39, yosin_UTC9 wrote: > nit: s/"/'/ Done.
	27 chrome.gpuBenchmarking.pointerActionSequence(pointerActions, step2);
	yosin_UTC9 2017/05/17 10:17:58 nit: Please add check for \|chrome\| and \|chrome.gpu nit: Please add check for \|chrome\| and \|chrome.gpuBenchmarking\|. See http://crrev.com/2891693002 to use \|chrome.gpuBenchmarking\| with \|Promise\|. yoichio 2017/05/18 09:31:49 Done. Show quoted text On 2017/05/17 10:17:58, yosin_UTC9 wrote: > nit: Please add check for \|chrome\| and \|chrome.gpuBenchmarking\|. > > See http://crrev.com/2891693002 to use \|chrome.gpuBenchmarking\| with \|Promise\|. Done.
	28 };

	29 </script>

OLD	NEW