Issue 2889693004: Fixes for review comments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2889693004: Fixes for review comments. (Closed)

Created:
3 years, 7 months ago by scheglov

Modified:
3 years, 7 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -11 lines)			Patch
	M	pkg/front_end/lib/src/incremental/file_state.dart	View		1 chunk	+1 line, -3 lines	0 comments	Download
	M	pkg/front_end/lib/src/incremental_kernel_generator_impl.dart	View		4 chunks	+8 lines, -8 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

3 years, 7 months ago (2017-05-17 15:31:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ae10e16d71b0f70d3945c8f93126922c0775b18c (presubmit successful).