chromeos: Refactor shelf to create ShelfView earlier in startup

ash/shell.h

Index: ash/shell.h
diff --git a/ash/shell.h b/ash/shell.h
index e3991f2b5652814d4b4b2ed29bc143b5cf53b18d..18effd8d96c6b99c6620be716c51c18e708b03ff 100644
--- a/ash/shell.h
+++ b/ash/shell.h
@@ -522,10 +522,6 @@ class ASH_EXPORT Shell : public SessionObserver,
   // returned object.
   ash::FirstRunHelper* CreateFirstRunHelper();
 
-  // Creates the ShelfView for each display and populates it with items.
-  // Called after the user session is active and profile is available.
-  void CreateShelfView();
-
   void SetLargeCursorSizeInDip(int large_cursor_size_in_dip);
 
   // Toggles cursor compositing on/off. Native cursor is disabled when cursor
@@ -654,6 +650,10 @@ class ASH_EXPORT Shell : public SessionObserver,
   void OnLoginStatusChanged(LoginStatus login_status) override;
   void OnLockStateChanged(bool locked) override;
 
+  // Finalizes the shelf state. Called after the user session is active and
+  // profile is available.

[msw, 2017/05/16 22:42:00]

nit: 'the profile'

[James Cook, 2017/05/17 16:16:13]

Done.

+  void InitializeShelf();

[James Cook, 2017/05/16 21:32:35]

Private visibility is best visibility!

[msw, 2017/05/16 22:42:00]

Acknowledged.

+
   // Callback for prefs::ConnectToPrefService.
   void OnPrefServiceInitialized(std::unique_ptr<::PrefService> pref_service);