Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: ash/public/interfaces/shelf.mojom

Issue 2889673002: chromeos: Refactor shelf to create ShelfView earlier in startup (Closed)
Patch Set: Move ShelfView to initializer list Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/root_window_controller.h » ('j') | ash/root_window_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/public/interfaces/shelf.mojom
diff --git a/ash/public/interfaces/shelf.mojom b/ash/public/interfaces/shelf.mojom
index 10127072e8934aa5737e124cc0ed9ba2eb746219..a630baf7e115dddde3eb277a512f6d27afdcba43 100644
--- a/ash/public/interfaces/shelf.mojom
+++ b/ash/public/interfaces/shelf.mojom
@@ -73,7 +73,9 @@ interface ShelfController {
// ShelfObserver is notified on shelf changes; used to persist profile settings.
interface ShelfObserver {
- OnShelfCreated(int64 display_id);
+ // TODO(jamescook): Eliminate all these methods and use the ash pref service
+ // to observe and to set prefs.
James Cook 2017/05/16 21:32:35 I think this could dramatically simplify ash/chrom
msw 2017/05/16 22:41:59 Acknowledged. Maybe file a bug to track that idea
James Cook 2017/05/17 16:16:12 Done.
+ OnShelfInitialized(int64 display_id);
OnAlignmentChanged(ShelfAlignment alignment, int64 display_id);
OnAutoHideBehaviorChanged(ShelfAutoHideBehavior auto_hide, int64 display_id);
};
« no previous file with comments | « no previous file | ash/root_window_controller.h » ('j') | ash/root_window_controller.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698