chromeos: Refactor shelf to create ShelfView earlier in startup

ash/shelf/shelf_widget_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/shelf/shelf_widget.h"
 
 #include "ash/root_window_controller.h"
 #include "ash/shelf/shelf_constants.h"
 #include "ash/shelf/shelf_layout_manager.h"
 #include "ash/shelf/shelf_view.h"
 #include "ash/shelf/wm_shelf.h"
 #include "ash/shell.h"
 #include "ash/shell_port.h"
 #include "ash/system/status_area_widget.h"
 #include "ash/test/ash_test_base.h"
 #include "ash/test/ash_test_helper.h"
 #include "ash/test/shelf_view_test_api.h"
+#include "ash/test/test_shell_delegate.h"
 #include "ash/wm/window_util.h"
 #include "ash/wm_window.h"
 #include "ui/aura/window_event_dispatcher.h"
 #include "ui/display/display.h"
 #include "ui/events/event_utils.h"
 #include "ui/views/view.h"
 #include "ui/views/widget/widget.h"
 
 namespace ash {
-
 namespace {
 
 ShelfWidget* GetShelfWidget() {
   return test::AshTestBase::GetPrimaryShelf()->shelf_widget();
 }
 
 ShelfLayoutManager* GetShelfLayoutManager() {
   return GetShelfWidget()->shelf_layout_manager();
 }
 
-}  // namespace
-
-using ShelfWidgetTest = test::AshTestBase;
-
 void TestLauncherAlignment(WmWindow* root,
                            ShelfAlignment alignment,
                            const gfx::Rect& expected) {
   root->GetRootWindowController()->GetShelf()->SetAlignment(alignment);
   EXPECT_EQ(expected.ToString(),
             root->GetDisplayNearestWindow().work_area().ToString());
 }
 
+using ShelfWidgetTest = test::AshTestBase;
+
 TEST_F(ShelfWidgetTest, TestAlignment) {
   UpdateDisplay("400x400");
   {
     SCOPED_TRACE("Single Bottom");
     TestLauncherAlignment(ShellPort::Get()->GetPrimaryRootWindow(),
                           SHELF_ALIGNMENT_BOTTOM, gfx::Rect(0, 0, 400, 352));
   }
   {
     SCOPED_TRACE("Single Locked");
     TestLauncherAlignment(ShellPort::Get()->GetPrimaryRootWindow(),
@@ skipping 256 matching lines @@
   {
     gfx::Point event_location(20, shelf_bounds.y() - 1);
     ui::TouchEvent touch(
         ui::ET_TOUCH_PRESSED, event_location, ui::EventTimeForNow(),
         ui::PointerDetails(ui::EventPointerType::POINTER_TYPE_TOUCH, 0));
     EXPECT_EQ(shelf_widget->GetNativeWindow(),
               targeter->FindTargetForEvent(root, &touch));
   }
 }
 
-namespace {
+class ShelfWidgetAfterLoginTest : public test::AshTestBase {
+ public:
+  ShelfWidgetAfterLoginTest() { set_start_session(false); }
+  ~ShelfWidgetAfterLoginTest() override = default;
 
-// A ShellObserver that sets the shelf alignment and auto hide behavior when the
-// shelf is created, to simulate ChromeLauncherController's behavior.
-class ShelfInitializer : public ShellObserver {
- public:
-  ShelfInitializer(ShelfAlignment alignment, ShelfAutoHideBehavior auto_hide)
-      : alignment_(alignment), auto_hide_(auto_hide) {
-    Shell::Get()->AddShellObserver(this);
-  }
-  ~ShelfInitializer() override { Shell::Get()->RemoveShellObserver(this); }
-
-  // ShellObserver:
-  void OnShelfCreatedForRootWindow(WmWindow* root_window) override {
-    WmShelf* shelf = root_window->GetRootWindowController()->GetShelf();
-    shelf->SetAlignment(alignment_);
-    shelf->SetAutoHideBehavior(auto_hide_);
-    shelf->UpdateVisibilityState();
-  }
-
- private:
-  ShelfAlignment alignment_;
-  ShelfAutoHideBehavior auto_hide_;
-
-  DISALLOW_COPY_AND_ASSIGN(ShelfInitializer);
-};
-
-class ShelfWidgetTestWithInitializer : public ShelfWidgetTest {
- public:
-  ShelfWidgetTestWithInitializer() { set_start_session(false); }
-  ~ShelfWidgetTestWithInitializer() override {}
-
-  void TestCreateShelfWithInitialValues(
-      ShelfAlignment initial_alignment,
-      ShelfAutoHideBehavior initial_auto_hide_behavior,
-      ShelfVisibilityState expected_shelf_visibility_state,
-      ShelfAutoHideState expected_shelf_auto_hide_state) {
-    ShelfInitializer initializer(initial_alignment, initial_auto_hide_behavior);
+  void TestShelf(ShelfAlignment alignment,
+                 ShelfAutoHideBehavior auto_hide_behavior,
+                 ShelfVisibilityState expected_shelf_visibility_state,
+                 ShelfAutoHideState expected_shelf_auto_hide_state) {
+    // Simulate login.
     SetUserLoggedIn(true);
     SetSessionStarted(true);
 
+    // Shelf components are created.

[msw, 2017/05/16 22:42:00]

Should this be disabling TestShellDelegate's ShelfInitializer and ensuring the
shelf has the expected initial values?

[James Cook, 2017/05/17 16:16:13]

I added a new test to check the initial values and moved the checks for shelf
components there (so we don't check for their existence 4 times). I also added a
check that the shelf view is created (which was kinda the point of this CL,
doh!).

     ShelfWidget* shelf_widget = GetShelfWidget();
     ASSERT_NE(nullptr, shelf_widget);
     WmShelf* shelf = GetPrimaryShelf();
     ASSERT_NE(nullptr, shelf);
     ShelfLayoutManager* shelf_layout_manager =
         shelf_widget->shelf_layout_manager();
     ASSERT_NE(nullptr, shelf_layout_manager);
 
-    EXPECT_EQ(initial_alignment, shelf->alignment());
-    EXPECT_EQ(initial_auto_hide_behavior, shelf->auto_hide_behavior());
+    // Simulate shelf settings being applied from profile prefs.
+    shelf->SetAlignment(alignment);
+    shelf->SetAutoHideBehavior(auto_hide_behavior);
+    shelf->UpdateVisibilityState();
+
+    // Settings are applied correctly.

[msw, 2017/05/16 22:42:00]

nit: "Ensure settings are applied correctly."

[James Cook, 2017/05/17 16:16:13]

Done.

+    EXPECT_EQ(alignment, shelf->alignment());
+    EXPECT_EQ(auto_hide_behavior, shelf->auto_hide_behavior());
     EXPECT_EQ(expected_shelf_visibility_state,
               shelf_layout_manager->visibility_state());
     EXPECT_EQ(expected_shelf_auto_hide_state,
               shelf_layout_manager->auto_hide_state());
   }
 
  private:
-  DISALLOW_COPY_AND_ASSIGN(ShelfWidgetTestWithInitializer);
+  DISALLOW_COPY_AND_ASSIGN(ShelfWidgetAfterLoginTest);
 };
 
-}  // namespace
-
-TEST_F(ShelfWidgetTestWithInitializer, CreateAutoHideAlwaysShelf) {
+TEST_F(ShelfWidgetAfterLoginTest, CreateAutoHideAlwaysShelf) {
   // The actual auto hide state is shown because there are no open windows.
-  TestCreateShelfWithInitialValues(SHELF_ALIGNMENT_BOTTOM,
-                                   SHELF_AUTO_HIDE_BEHAVIOR_ALWAYS,
-                                   SHELF_AUTO_HIDE, SHELF_AUTO_HIDE_SHOWN);
+  TestShelf(SHELF_ALIGNMENT_BOTTOM, SHELF_AUTO_HIDE_BEHAVIOR_ALWAYS,
+            SHELF_AUTO_HIDE, SHELF_AUTO_HIDE_SHOWN);
 }
 
-TEST_F(ShelfWidgetTestWithInitializer, CreateAutoHideNeverShelf) {
+TEST_F(ShelfWidgetAfterLoginTest, CreateAutoHideNeverShelf) {
   // The auto hide state 'HIDDEN' is returned for any non-auto-hide behavior.
-  TestCreateShelfWithInitialValues(SHELF_ALIGNMENT_LEFT,
-                                   SHELF_AUTO_HIDE_BEHAVIOR_NEVER,
-                                   SHELF_VISIBLE, SHELF_AUTO_HIDE_HIDDEN);
+  TestShelf(SHELF_ALIGNMENT_LEFT, SHELF_AUTO_HIDE_BEHAVIOR_NEVER, SHELF_VISIBLE,
+            SHELF_AUTO_HIDE_HIDDEN);
 }
 
-TEST_F(ShelfWidgetTestWithInitializer, CreateAutoHideAlwaysHideShelf) {
+TEST_F(ShelfWidgetAfterLoginTest, CreateAutoHideAlwaysHideShelf) {
   // The auto hide state 'HIDDEN' is returned for any non-auto-hide behavior.
-  TestCreateShelfWithInitialValues(SHELF_ALIGNMENT_RIGHT,
-                                   SHELF_AUTO_HIDE_ALWAYS_HIDDEN, SHELF_HIDDEN,
-                                   SHELF_AUTO_HIDE_HIDDEN);
+  TestShelf(SHELF_ALIGNMENT_RIGHT, SHELF_AUTO_HIDE_ALWAYS_HIDDEN, SHELF_HIDDEN,
+            SHELF_AUTO_HIDE_HIDDEN);
 }
 
-TEST_F(ShelfWidgetTestWithInitializer, CreateLockedShelf) {
+TEST_F(ShelfWidgetAfterLoginTest, CreateLockedShelf) {
   // The auto hide state 'HIDDEN' is returned for any non-auto-hide behavior.
-  TestCreateShelfWithInitialValues(SHELF_ALIGNMENT_BOTTOM_LOCKED,
-                                   SHELF_AUTO_HIDE_BEHAVIOR_NEVER,
-                                   SHELF_VISIBLE, SHELF_AUTO_HIDE_HIDDEN);
+  TestShelf(SHELF_ALIGNMENT_BOTTOM_LOCKED, SHELF_AUTO_HIDE_BEHAVIOR_NEVER,
+            SHELF_VISIBLE, SHELF_AUTO_HIDE_HIDDEN);
 }
 
+}  // namespace
 }  // namespace ash