chromeos: Refactor shelf to create ShelfView earlier in startup

ash/shelf/shelf_widget.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_SHELF_SHELF_WIDGET_H_
 #define ASH_SHELF_SHELF_WIDGET_H_
 
 #include <memory>
 
 #include "ash/ash_export.h"
@@ skipping 40 matching lines @@
   ShelfBackgroundType GetBackgroundType() const;
 
   // Hide the shelf behind a black bar during e.g. a user transition when |hide|
   // is true. The |animation_time_ms| will be used as animation duration.
   void HideShelfBehindBlackBar(bool hide, int animation_time_ms);
   bool IsShelfHiddenBehindBlackBar() const;
 
   ShelfLayoutManager* shelf_layout_manager() { return shelf_layout_manager_; }
   StatusAreaWidget* status_area_widget() const { return status_area_widget_; }
 
-  // Creates the shelf view and populates it with icons. Called after the user
-  // session is active (and hence the user profile is available).
-  ShelfView* CreateShelfView();
   void PostCreateShelf();
 
   bool IsShelfVisible() const;
 
   bool IsShowingAppList() const;
   bool IsShowingContextMenu() const;
   bool IsShowingOverflowBubble() const;
 
   // Sets the focus cycler.  Also adds the shelf to the cycle.
   void SetFocusCycler(FocusCycler* focus_cycler);
@@ skipping 20 matching lines @@
 
   // Overridden from views::WidgetObserver:
   void OnWidgetActivationChanged(views::Widget* widget, bool active) override;
 
   // ShelfBackgroundAnimatorObserver overrides:
   void UpdateShelfItemBackground(SkColor color) override;
 
   // ShelfLayoutManagerObserver overrides:
   void WillDeleteShelfLayoutManager() override;
 
+  // Internal implementation detail. Do not expose outside of tests.
+  ShelfView* shelf_view_for_testing() { return shelf_view_; }

[msw, 2017/05/16 22:42:00]

nit: const?

[James Cook, 2017/05/17 16:16:12]

Done.

+
  private:
   class DelegateView;
   friend class DelegateView;
 
   WmShelf* wm_shelf_;
 
   // Owned by the shelf container's window.
   ShelfLayoutManager* shelf_layout_manager_;
 
   // Owned by the native widget.
   StatusAreaWidget* status_area_widget_;
 
   // |delegate_view_| is the contents view of this widget and is cleaned up
   // during CloseChildWindows of the associated RootWindowController.
   DelegateView* delegate_view_;
-  // View containing the shelf items. Owned by the views hierarchy. Null when
-  // at the login screen.
-  ShelfView* shelf_view_;
+  // View containing the shelf items. Owned by the views hierarchy.
+  ShelfView* const shelf_view_;

[James Cook, 2017/05/16 21:32:35]

This "const" is basically the whole point of this CL. :-)

[msw, 2017/05/16 22:42:00]

Acknowledged.

   ShelfBackgroundAnimator background_animator_;
   bool activating_as_fallback_;
 
   DISALLOW_COPY_AND_ASSIGN(ShelfWidget);
 };
 
 }  // namespace ash
 
 #endif  // ASH_SHELF_SHELF_WIDGET_H_