chromeos: Refactor shelf to create ShelfView earlier in startup

ash/root_window_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_ROOT_WINDOW_CONTROLLER_H_
 #define ASH_ROOT_WINDOW_CONTROLLER_H_
 
 #include <map>
 #include <memory>
 #include <vector>
@@ skipping 121 matching lines @@
   const WmWindow* GetWindow() const;
 
   WorkspaceController* workspace_controller() {
     return workspace_controller_.get();
   }
 
   wm::WorkspaceWindowState GetWorkspaceWindowState();
 
   WmShelf* wm_shelf() const { return wm_shelf_.get(); }
 
+  // TODO(jamescook): Eliminate this. It always returns true after the

[msw, 2017/05/16 22:42:00]

nit: There's only two occurrences, maybe just do this now by inlining
wm_shelf()->shelf_widget()? (we should also combine |wm_shelf()| and
|GetShelf()| down the line)

[James Cook, 2017/05/17 16:16:12]

Done. As I suspected, it wasn't needed at all.

+  // layout managers are initialized.
   bool HasShelf();
 
   WmShelf* GetShelf();
 
-  // Creates the shelf view for this root window and notifies observers.
-  void CreateShelfView();
+  // Initializes the shelf for this root window and notifies observers.
+  void InitializeShelf();
 
   // Get touch HUDs associated with this root window controller.
   TouchHudDebug* touch_hud_debug() const { return touch_hud_debug_; }
   TouchHudProjection* touch_hud_projection() const {
     return touch_hud_projection_;
   }
 
   // Set touch HUDs for this root window controller. The root window controller
   // will not own the HUDs; their lifetimes are managed by themselves. Whenever
   // the widget showing a HUD is being destroyed (e.g. because of detaching a
@@ skipping 187 matching lines @@
   std::unique_ptr<views::MenuModelAdapter> menu_model_adapter_;
   std::unique_ptr<views::MenuRunner> menu_runner_;
 
   std::unique_ptr<StackingController> stacking_controller_;
 
   // The shelf controller for this root window. Exists for the entire lifetime
   // of the RootWindowController so that it is safe for observers to be added
   // to it during construction of the shelf widget and status tray.
   std::unique_ptr<WmShelf> wm_shelf_;
 
+  // TODO(jamescook): Eliminate this. It is left over from legacy shelf code and
+  // doesn't mean anything in particular.
+  bool shelf_initialized_ = false;
+
   std::unique_ptr<SystemWallpaperController> system_wallpaper_;
 
   std::unique_ptr<BootSplashScreen> boot_splash_screen_;
   // Responsible for initializing TouchExplorationController when spoken
   // feedback is on.
   std::unique_ptr<AshTouchExplorationManager> touch_exploration_manager_;
 
   // Heads-up displays for touch events. These HUDs are not owned by the root
   // window controller and manage their own lifetimes.
   TouchHudDebug* touch_hud_debug_ = nullptr;
@@ skipping 11 matching lines @@
 
 // On classic ash, returns the RootWindowController for the given |root_window|.
 // On mus ash, returns the RootWindowController for the primary display.
 // See RootWindowController class comment above.
 ASH_EXPORT RootWindowController* GetRootWindowController(
     const aura::Window* root_window);
 
 }  // namespace ash
 
 #endif  // ASH_ROOT_WINDOW_CONTROLLER_H_