Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2889663004: [DO NOT COMMIT][Offline Pages] Moving Offline Page Cache to cache directory.

Created:
3 years, 7 months ago by romax
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, romax+watch_chromium.org, dewittj+watch_chromium.org, fgorski+watch_chromium.org, vmpstr+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, danakj+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DO NOT COMMIT][Offline Pages] Moving Offline Page Cache to cache directory. file_util_win change. BUG=NONE

Patch Set 1 #

Patch Set 2 : file_util_win change. #

Patch Set 3 : again? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -109 lines) Patch
M base/files/file_util_win.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_model_factory.cc View 2 chunks +19 lines, -8 lines 0 comments Download
M chrome/browser/android/offline_pages/test_offline_page_model_builder.cc View 2 chunks +16 lines, -2 lines 0 comments Download
M components/offline_pages/core/archive_manager.h View 5 chunks +13 lines, -7 lines 0 comments Download
M components/offline_pages/core/archive_manager.cc View 5 chunks +45 lines, -18 lines 0 comments Download
M components/offline_pages/core/archive_manager_unittest.cc View 17 chunks +94 lines, -23 lines 0 comments Download
M components/offline_pages/core/offline_page_model_impl.h View 3 chunks +6 lines, -2 lines 0 comments Download
M components/offline_pages/core/offline_page_model_impl.cc View 7 chunks +26 lines, -16 lines 0 comments Download
M components/offline_pages/core/offline_page_model_impl_unittest.cc View 5 chunks +55 lines, -9 lines 0 comments Download
M components/offline_pages/core/offline_page_storage_manager.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/offline_pages/core/offline_page_storage_manager.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M components/offline_pages/core/offline_page_storage_manager_unittest.cc View 3 chunks +14 lines, -16 lines 0 comments Download
M components/offline_pages/core/offline_page_types.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (3 generated)
romax
The CQ bit was checked by romax@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-18 21:29:13 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889663004/40001
3 years, 7 months ago (2017-05-18 21:30:47 UTC) #2
romax
3 years, 7 months ago (2017-05-18 21:31:50 UTC) #3
The CQ bit was unchecked by romax@chromium.org

Powered by Google App Engine
This is Rietveld 408576698