Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Unified Diff: third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp

Issue 2889653002: Remove cullRect() from PaintOpBuffer. (Closed)
Patch Set: movecullrect2 rebase-once-and-for-all Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp b/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
index ebb192b3203d7f7e29c8d392cc48e36ffad12108..690e5ac6734038642fbd035132b96015463050a8 100644
--- a/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
+++ b/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
@@ -1207,6 +1207,11 @@ static bool PixelsDiffer(SkColor p1, SkColor p2) {
PixelComponentsDiffer(SkColorGetB(p1), SkColorGetB(p2));
}
+// This method is used to graphically verify any under invalidation when
+// RuntimeEnabledFeatures::paintUnderInvalidationCheckingEnabled is being
+// used. It compares the last recording made by GraphicsLayer::Paint against
+// |new_record|, by rastering both into bitmaps. Any differences are colored
+// as dark red.
void GraphicsLayer::CheckPaintUnderInvalidations(
sk_sp<PaintRecord> new_record) {
if (!DrawsContent())
@@ -1283,7 +1288,7 @@ void GraphicsLayer::CheckPaintUnderInvalidations(
recorder.getRecordingCanvas()->drawBitmap(new_bitmap, rect.X(), rect.Y());
sk_sp<PaintRecord> record = recorder.finishRecordingAsPicture();
GetPaintController().AppendDebugDrawingAfterCommit(
- *this, record, OffsetFromLayoutObjectWithSubpixelAccumulation());
+ *this, record, rect, OffsetFromLayoutObjectWithSubpixelAccumulation());
}
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp ('k') | third_party/WebKit/Source/platform/graphics/Image.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698