Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Unified Diff: cc/paint/display_item_list.cc

Issue 2889653002: Remove cullRect() from PaintOpBuffer. (Closed)
Patch Set: movecullrect2 rebase-once-and-for-all Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/paint/discardable_image_map_unittest.cc ('k') | cc/paint/display_item_list_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/paint/display_item_list.cc
diff --git a/cc/paint/display_item_list.cc b/cc/paint/display_item_list.cc
index 2837bf74062bb29c984795d08e95be2b12bdb52a..4161df1a8dbefde359ef68cdba124aa19519830f 100644
--- a/cc/paint/display_item_list.cc
+++ b/cc/paint/display_item_list.cc
@@ -98,7 +98,7 @@ NOINLINE DISABLE_CFI_PERF void RasterItem(const DisplayItem& base_item,
break;
case DisplayItem::DRAWING: {
const auto& item = static_cast<const DrawingDisplayItem&>(base_item);
- if (canvas->quickReject(item.picture->cullRect()))
+ if (canvas->quickReject(item.bounds))
break;
// TODO(enne): Maybe the PaintRecord itself could know whether this
@@ -427,15 +427,15 @@ DisplayItemList::CreateTracedValue(bool include_items) const {
state->EndArray();
state->BeginArray("cullRect");
- state->AppendInteger(item.picture->cullRect().x());
- state->AppendInteger(item.picture->cullRect().y());
- state->AppendInteger(item.picture->cullRect().width());
- state->AppendInteger(item.picture->cullRect().height());
+ state->AppendInteger(item.bounds.x());
+ state->AppendInteger(item.bounds.y());
+ state->AppendInteger(item.bounds.width());
+ state->AppendInteger(item.bounds.height());
state->EndArray();
std::string b64_picture;
- PictureDebugUtil::SerializeAsBase64(ToSkPicture(item.picture).get(),
- &b64_picture);
+ PictureDebugUtil::SerializeAsBase64(
+ ToSkPicture(item.picture, item.bounds).get(), &b64_picture);
state->SetString("skp64", b64_picture);
state->EndDictionary();
break;
« no previous file with comments | « cc/paint/discardable_image_map_unittest.cc ('k') | cc/paint/display_item_list_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698