Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Side by Side Diff: ui/compositor/paint_recorder.cc

Issue 2889653002: Remove cullRect() from PaintOpBuffer. (Closed)
Patch Set: movecullrect2 rebase-once-and-for-all Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/compositor/paint_recorder.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/compositor/paint_recorder.h" 5 #include "ui/compositor/paint_recorder.h"
6 6
7 #include "cc/paint/display_item_list.h" 7 #include "cc/paint/display_item_list.h"
8 #include "cc/paint/drawing_display_item.h" 8 #include "cc/paint/drawing_display_item.h"
9 #include "cc/paint/paint_recorder.h" 9 #include "cc/paint/paint_recorder.h"
10 #include "third_party/skia/include/core/SkRefCnt.h" 10 #include "third_party/skia/include/core/SkRefCnt.h"
11 #include "ui/compositor/paint_cache.h" 11 #include "ui/compositor/paint_cache.h"
12 #include "ui/compositor/paint_context.h" 12 #include "ui/compositor/paint_context.h"
13 #include "ui/gfx/skia_util.h" 13 #include "ui/gfx/skia_util.h"
14 14
15 namespace ui { 15 namespace ui {
16 16
17 // This class records a reference to the context, the canvas returned 17 // This class records a reference to the context, the canvas returned
18 // by its recorder_, and the cache. Thus all 3 of these must remain 18 // by its recorder_, and the cache. Thus all 3 of these must remain
19 // valid for the lifetime of this object. 19 // valid for the lifetime of this object.
20 PaintRecorder::PaintRecorder(const PaintContext& context, 20 PaintRecorder::PaintRecorder(const PaintContext& context,
21 const gfx::Size& recording_size, 21 const gfx::Size& recording_size,
22 PaintCache* cache) 22 PaintCache* cache)
23 : context_(context), 23 : context_(context),
24 canvas_(context.recorder_->beginRecording( 24 canvas_(context.recorder_->beginRecording(
25 gfx::RectToSkRect(gfx::Rect(recording_size))), 25 gfx::RectToSkRect(gfx::Rect(recording_size))),
26 context.device_scale_factor_), 26 context.device_scale_factor_),
27 cache_(cache), 27 cache_(cache),
28 bounds_in_layer_(context.ToLayerSpaceBounds(recording_size)) { 28 recording_size_(recording_size) {
29 #if DCHECK_IS_ON() 29 #if DCHECK_IS_ON()
30 DCHECK(!context.inside_paint_recorder_); 30 DCHECK(!context.inside_paint_recorder_);
31 context.inside_paint_recorder_ = true; 31 context.inside_paint_recorder_ = true;
32 #endif 32 #endif
33 } 33 }
34 34
35 PaintRecorder::PaintRecorder(const PaintContext& context, 35 PaintRecorder::PaintRecorder(const PaintContext& context,
36 const gfx::Size& recording_size) 36 const gfx::Size& recording_size)
37 : PaintRecorder(context, recording_size, nullptr) { 37 : PaintRecorder(context, recording_size, nullptr) {
38 } 38 }
39 39
40 PaintRecorder::~PaintRecorder() { 40 PaintRecorder::~PaintRecorder() {
41 #if DCHECK_IS_ON() 41 #if DCHECK_IS_ON()
42 context_.inside_paint_recorder_ = false; 42 context_.inside_paint_recorder_ = false;
43 #endif 43 #endif
44 gfx::Rect bounds_in_layer = context_.ToLayerSpaceBounds(recording_size_);
44 const auto& item = 45 const auto& item =
45 context_.list_->CreateAndAppendDrawingItem<cc::DrawingDisplayItem>( 46 context_.list_->CreateAndAppendDrawingItem<cc::DrawingDisplayItem>(
46 bounds_in_layer_, context_.recorder_->finishRecordingAsPicture()); 47 bounds_in_layer, context_.recorder_->finishRecordingAsPicture(),
48 gfx::RectToSkRect(gfx::Rect(recording_size_)));
47 if (cache_) 49 if (cache_)
48 cache_->SetCache(item); 50 cache_->SetCache(item);
49 } 51 }
50 52
51 } // namespace ui 53 } // namespace ui
OLDNEW
« no previous file with comments | « ui/compositor/paint_recorder.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698