Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1377)

Unified Diff: chrome/browser/memory/tab_manager_delegate_chromeos.cc

Issue 2889523003: Add kApplicationIdKey for ShellSurface::GetApplicationId and SetApplicationId (Closed)
Patch Set: Fix nits. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/memory/tab_manager_delegate_chromeos.cc
diff --git a/chrome/browser/memory/tab_manager_delegate_chromeos.cc b/chrome/browser/memory/tab_manager_delegate_chromeos.cc
index 39a0f0cb50049b8a70f0d4c4847fb22da97faa94..57da59a6c4d244bffb1c0f29cc3b905ce91d7036 100644
--- a/chrome/browser/memory/tab_manager_delegate_chromeos.cc
+++ b/chrome/browser/memory/tab_manager_delegate_chromeos.cc
@@ -75,8 +75,10 @@ aura::client::ActivationClient* GetActivationClient() {
bool IsArcWindow(aura::Window* window) {
if (!window || window->GetName() != kExoShellSurfaceWindowName)
return false;
- std::string application_id = exo::ShellSurface::GetApplicationId(window);
Yusuke Sato 2017/05/19 16:55:28 FYI the code has been removed: https://codereview.
yawano 2017/05/22 07:33:19 Thank you for letting me know about this! Rebased
- return base::StartsWith(application_id, kArcProcessNamePrefix,
+ const std::string* application_id =
+ exo::ShellSurface::GetApplicationId(window);
+ return application_id &&
+ base::StartsWith(*application_id, kArcProcessNamePrefix,
base::CompareCase::SENSITIVE);
}

Powered by Google App Engine
This is Rietveld 408576698