components/exo/shell_surface.h - Issue 2889523003: Add kApplicationIdKey for ShellSurface::GetApplicationId and SetApplicationId

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/exo/shell_surface.h

Issue 2889523003: Add kApplicationIdKey for ShellSurface::GetApplicationId and SetApplicationId (Closed)

Patch Set: Fix shell_surface_unittest. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/exo/shell_surface.h

diff --git a/components/exo/shell_surface.h b/components/exo/shell_surface.h

index 132508ed4802cba49a756b7b3d89d1d3803c770c..0045a317dec1b1b394d815619f40de257a000595 100644

--- a/components/exo/shell_surface.h

+++ b/components/exo/shell_surface.h

@@ -149,7 +149,7 @@ class ShellSurface : public SurfaceDelegate,

// Sets the application ID for the window. The application ID identifies the

// general class of applications to which the window belongs.

static void SetApplicationId(aura::Window* window, const std::string& id);

- static const std::string GetApplicationId(aura::Window* window);

+ static const std::string* GetApplicationId(aura::Window* window);

// Set the application ID for the surface.

void SetApplicationId(const std::string& application_id);