Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2889453002: Move bundle filter from BaseChannel to RtpTransport. (Closed)

Created:
3 years, 7 months ago by Zach Stein
Modified:
3 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move bundle filter from BaseChannel to RtpTransport. Subsumed by https://codereview.chromium.org/2890263003/ BUG=webrtc:7013

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -11 lines) Patch
M webrtc/pc/channel.h View 4 chunks +5 lines, -3 lines 2 comments Download
M webrtc/pc/channel.cc View 5 chunks +12 lines, -4 lines 0 comments Download
M webrtc/pc/channel_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/pc/rtptransport.h View 3 chunks +9 lines, -0 lines 0 comments Download
M webrtc/pc/rtptransport.cc View 1 chunk +11 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
Zach Stein
Not sure if this is the right approach or not - let me know what ...
3 years, 7 months ago (2017-05-15 22:44:01 UTC) #2
zhihuang1
On 2017/05/15 22:44:01, Zach Stein wrote: > Not sure if this is the right approach ...
3 years, 7 months ago (2017-05-16 17:59:01 UTC) #3
Taylor Brandstetter
This looks good, but moving BundleFilter to RtpTransport doesn't serve much purpose in itself; could ...
3 years, 7 months ago (2017-05-17 02:12:42 UTC) #4
Zach Stein
3 years, 6 months ago (2017-05-30 19:08:38 UTC) #5
https://codereview.webrtc.org/2889453002/diff/1/webrtc/pc/channel.h
File webrtc/pc/channel.h (right):

https://codereview.webrtc.org/2889453002/diff/1/webrtc/pc/channel.h#newcode200
webrtc/pc/channel.h:200: bool HandlesPayloadType(int payload_type);
On 2017/05/17 02:12:42, Taylor Brandstetter wrote:
> const?

Done.

https://codereview.webrtc.org/2889453002/diff/1/webrtc/pc/rtptransport.cc
File webrtc/pc/rtptransport.cc (right):

https://codereview.webrtc.org/2889453002/diff/1/webrtc/pc/rtptransport.cc#new...
webrtc/pc/rtptransport.cc:100: }
On 2017/05/17 02:12:42, Taylor Brandstetter wrote:
> nit: newline

Done.

Powered by Google App Engine
This is Rietveld 408576698