Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: ui/aura/mus/property_converter.h

Issue 2889443002: mash: Add type names to PropertyConverter::Register*Property. (Closed)
Patch Set: Rename to RegisterImageSkiaProperty, update test identifiers. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/aura/mus/property_converter.h
diff --git a/ui/aura/mus/property_converter.h b/ui/aura/mus/property_converter.h
index f31751a7680d391322b57145267c6359bc3c16dd..95c1ca22395689fcd74526632b2bf38243b8723c 100644
--- a/ui/aura/mus/property_converter.h
+++ b/ui/aura/mus/property_converter.h
@@ -78,9 +78,8 @@ class AURA_EXPORT PropertyConverter {
// Register a property to support conversion between mus and aura.
// |validator| is a callback used to validate incoming values from
// transport_data; if it returns false, the value is rejected.
- // TODO(msw): Include type names in RegisterProperty function names.
template <typename T>
- void RegisterProperty(
+ void RegisterPrimitiveProperty(
const WindowProperty<T>* property,
const char* transport_name,
const base::RepeatingCallback<bool(int64_t)>& validator) {
@@ -95,17 +94,17 @@ class AURA_EXPORT PropertyConverter {
}
// Register owned properties to support conversion between mus and aura.
- // TODO(msw): Include type names in RegisterProperty function names.
- void RegisterProperty(const WindowProperty<gfx::ImageSkia*>* property,
- const char* transport_name);
- void RegisterProperty(const WindowProperty<gfx::Rect*>* property,
- const char* transport_name);
- void RegisterProperty(const WindowProperty<gfx::Size*>* property,
- const char* transport_name);
- void RegisterProperty(const WindowProperty<std::string*>* property,
- const char* transport_name);
- void RegisterProperty(const WindowProperty<base::string16*>* property,
- const char* transport_name);
+ void RegisterImageSkiaProperty(
+ const WindowProperty<gfx::ImageSkia*>* property,
+ const char* transport_name);
+ void RegisterRectProperty(const WindowProperty<gfx::Rect*>* property,
+ const char* transport_name);
+ void RegisterSizeProperty(const WindowProperty<gfx::Size*>* property,
+ const char* transport_name);
+ void RegisterStringProperty(const WindowProperty<std::string*>* property,
+ const char* transport_name);
+ void RegisterString16Property(const WindowProperty<base::string16*>* property,
+ const char* transport_name);
private:
// Contains data needed to store and convert primitive-type properties.
« no previous file with comments | « chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc ('k') | ui/aura/mus/property_converter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698