mash: Add type names to PropertyConverter::Register*Property.

ui/aura/mus/property_converter.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/aura/mus/property_converter.h"
 
 #include "base/memory/ptr_util.h"
 #include "mojo/public/cpp/bindings/type_converter.h"
 #include "services/ui/public/cpp/property_type_converters.h"
 #include "services/ui/public/interfaces/window_manager.mojom.h"
@@ skipping 48 matching lines @@
 PropertyConverter::PrimitiveProperty::~PrimitiveProperty() {}
 
 // static
 base::RepeatingCallback<bool(int64_t)>
 PropertyConverter::CreateAcceptAnyValueCallback() {
   return base::Bind(&AlwaysTrue);
 }
 
 PropertyConverter::PropertyConverter() {
   // Add known aura properties with associated mus properties.
-  RegisterProperty(client::kAlwaysOnTopKey,
-                   ui::mojom::WindowManager::kAlwaysOnTop_Property,
-                   CreateAcceptAnyValueCallback());
-  RegisterProperty(client::kAppIconKey,
-                   ui::mojom::WindowManager::kAppIcon_Property);
-  RegisterProperty(client::kImmersiveFullscreenKey,
-                   ui::mojom::WindowManager::kImmersiveFullscreen_Property,
-                   CreateAcceptAnyValueCallback());
-  RegisterProperty(client::kNameKey, ui::mojom::WindowManager::kName_Property);
-  RegisterProperty(client::kPreferredSize,
-                   ui::mojom::WindowManager::kPreferredSize_Property);
-  RegisterProperty(client::kResizeBehaviorKey,
-                   ui::mojom::WindowManager::kResizeBehavior_Property,
-                   base::Bind(&ValidateResizeBehaviour));
-  RegisterProperty(client::kRestoreBoundsKey,
-                   ui::mojom::WindowManager::kRestoreBounds_Property);
-  RegisterProperty(client::kShowStateKey,
-                   ui::mojom::WindowManager::kShowState_Property,
-                   base::Bind(&ValidateShowState));
-  RegisterProperty(client::kWindowIconKey,
-                   ui::mojom::WindowManager::kWindowIcon_Property);
-  RegisterProperty(client::kTitleKey,
-                   ui::mojom::WindowManager::kWindowTitle_Property);
+  RegisterPrimitiveProperty(client::kAlwaysOnTopKey,
+                            ui::mojom::WindowManager::kAlwaysOnTop_Property,
+                            CreateAcceptAnyValueCallback());

[Elliot Glaysher, 2017/05/15 22:46:04]

Now that the method name differs, should it be sorted by kKey or should it be
sorted by [register_name, kKey]?

[msw, 2017/05/15 22:52:54]

Good question, I slightly prefer still sorting by key name, but maybe that's
just to avoid churn/work :) Do you prefer sorting by function type/name first?

[msw, 2017/05/15 23:03:58]

I reordered them, as per Elliot's offline request.

+  RegisterImageProperty(client::kAppIconKey,
+                        ui::mojom::WindowManager::kAppIcon_Property);
+  RegisterPrimitiveProperty(
+      client::kImmersiveFullscreenKey,
+      ui::mojom::WindowManager::kImmersiveFullscreen_Property,
+      CreateAcceptAnyValueCallback());
+  RegisterStringProperty(client::kNameKey,
+                         ui::mojom::WindowManager::kName_Property);
+  RegisterSizeProperty(client::kPreferredSize,
+                       ui::mojom::WindowManager::kPreferredSize_Property);
+  RegisterPrimitiveProperty(client::kResizeBehaviorKey,
+                            ui::mojom::WindowManager::kResizeBehavior_Property,
+                            base::Bind(&ValidateResizeBehaviour));
+  RegisterRectProperty(client::kRestoreBoundsKey,
+                       ui::mojom::WindowManager::kRestoreBounds_Property);
+  RegisterPrimitiveProperty(client::kShowStateKey,
+                            ui::mojom::WindowManager::kShowState_Property,
+                            base::Bind(&ValidateShowState));
+  RegisterImageProperty(client::kWindowIconKey,
+                        ui::mojom::WindowManager::kWindowIcon_Property);
+  RegisterString16Property(client::kTitleKey,
+                           ui::mojom::WindowManager::kWindowTitle_Property);
 }
 
 PropertyConverter::~PropertyConverter() {}
 
 bool PropertyConverter::IsTransportNameRegistered(
     const std::string& name) const {
   return transport_names_.count(name) > 0;
 }
 
 bool PropertyConverter::ConvertPropertyForTransport(
@@ skipping 179 matching lines @@
                  << transport_name;
         return false;
       }
       *value = v;
       return true;
     }
   }
   return false;
 }
 
-void PropertyConverter::RegisterProperty(
+void PropertyConverter::RegisterImageProperty(
     const WindowProperty<gfx::ImageSkia*>* property,
     const char* transport_name) {
   image_properties_[property] = transport_name;
   transport_names_.insert(transport_name);
 }
 
-void PropertyConverter::RegisterProperty(
+void PropertyConverter::RegisterRectProperty(
     const WindowProperty<gfx::Rect*>* property,
     const char* transport_name) {
   rect_properties_[property] = transport_name;
   transport_names_.insert(transport_name);
 }
 
-void PropertyConverter::RegisterProperty(
+void PropertyConverter::RegisterSizeProperty(
     const WindowProperty<gfx::Size*>* property,
     const char* transport_name) {
   size_properties_[property] = transport_name;
   transport_names_.insert(transport_name);
 }
 
-void PropertyConverter::RegisterProperty(
+void PropertyConverter::RegisterStringProperty(
     const WindowProperty<std::string*>* property,
     const char* transport_name) {
   string_properties_[property] = transport_name;
   transport_names_.insert(transport_name);
 }
 
-void PropertyConverter::RegisterProperty(
+void PropertyConverter::RegisterString16Property(
     const WindowProperty<base::string16*>* property,
     const char* transport_name) {
   string16_properties_[property] = transport_name;
   transport_names_.insert(transport_name);
 }
 
 }  // namespace aura