Issue 288943005: Mojo: Add a utility to compare old mojom_bindings_generator.py output to the current one.

Issue 288943005: Mojo: Add a utility to compare old mojom_bindings_generator.py output to the current one. (Closed)

Created:
6 years, 7 months ago by viettrungluu

Modified:
6 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src

Visibility:
Public.

More Reviews

Description

Mojo: Add a utility to compare old mojom_bindings_generator.py output to the current one. Maybe one day I'll consider checking in golden files and making it a proper (automated) test ... but in the meanwhile it's still useful for refactoring the bindings generator code. R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270845

Patch Set 1 #

Total comments: 2

Patch Set 2 : foo #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+178 lines, -0 lines)			Patch
A +	mojo/public/tools/bindings/pylib/mojom_tests/support/__init__.py	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	mojo/public/tools/bindings/pylib/mojom_tests/support/find_files.py	View		1 chunk	+32 lines, -0 lines	0 comments	Download
A	mojo/public/tools/bindings/pylib/mojom_tests/support/run_bindings_generator.py	View	1	1 chunk	+47 lines, -0 lines	0 comments	Download
A	mojo/tools/check_mojom_golden_files.py	View		1 chunk	+99 lines, -0 lines	0 comments	Download
M	mojo/tools/test_runner.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

LGTM https://codereview.chromium.org/288943005/diff/1/mojo/public/tools/bindings/pylib/mojom_tests/support/run_bindings_generator.py File mojo/public/tools/bindings/pylib/mojom_tests/support/run_bindings_generator.py (right): https://codereview.chromium.org/288943005/diff/1/mojo/public/tools/bindings/pylib/mojom_tests/support/run_bindings_generator.py#newcode8 mojo/public/tools/bindings/pylib/mojom_tests/support/run_bindings_generator.py:8: nit: extra new line needed

6 years, 7 months ago (2014-05-15 22:50:30 UTC) #2

viettrungluu

Thanks. https://codereview.chromium.org/288943005/diff/1/mojo/public/tools/bindings/pylib/mojom_tests/support/run_bindings_generator.py File mojo/public/tools/bindings/pylib/mojom_tests/support/run_bindings_generator.py (right): https://codereview.chromium.org/288943005/diff/1/mojo/public/tools/bindings/pylib/mojom_tests/support/run_bindings_generator.py#newcode8 mojo/public/tools/bindings/pylib/mojom_tests/support/run_bindings_generator.py:8: On 2014/05/15 22:50:30, darin wrote: > nit: extra ...

6 years, 7 months ago (2014-05-15 23:17:17 UTC) #3

viettrungluu

6 years, 7 months ago (2014-05-15 23:18:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r270845 (presubmit successful).

Expand Messages | Collapse Messages