third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp - Issue 2889393003: Lazy initialization of the rendering thread in OfflineAudioContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

Issue 2889393003: Lazy initialization of the rendering thread in OfflineAudioContext (Closed)

Patch Set: Change thread creation location and add layout test Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webaudio/OfflineAudioContext.cpp ('K') | « third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp b/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

index e35b087652e1663a338b77707488110927f8aae1..232664aad1482a3945ced0de54968ac3c68618ea 100644

--- a/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp

@@ -46,8 +46,6 @@ OfflineAudioDestinationHandler::OfflineAudioDestinationHandler(

AudioBuffer* render_target)

: AudioDestinationHandler(node),

render_target_(render_target),

- render_thread_(

- Platform::Current()->CreateThread("offline audio renderer")),

frames_processed_(0),

frames_to_process_(0),

is_rendering_started_(false),

@@ -138,6 +136,11 @@ size_t OfflineAudioDestinationHandler::CallbackBufferSize() const {

NOTREACHED();

return 0;

}

+void OfflineAudioDestinationHandler::InitializeOfflineRenderThread() {

+ render_thread_ = Platform::Current()->CreateThread("offline audio renderer");

WebThread* OfflineAudioDestinationHandler::OfflineRenderThread() {

DCHECK(render_thread_);