Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: third_party/WebKit/Source/build/scripts/make_computed_style_base.py

Issue 2889353002: Generate diffs for properties that are generated in ComputedStyle (Closed)
Patch Set: Only check not inherited fields and fix fonts Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/build/scripts/make_computed_style_base.py
diff --git a/third_party/WebKit/Source/build/scripts/make_computed_style_base.py b/third_party/WebKit/Source/build/scripts/make_computed_style_base.py
index 26f434a33617114ac6131bbc736dc55678a82f2f..b84c93d4180595cc3c45f2229d41bca4255d22ef 100755
--- a/third_party/WebKit/Source/build/scripts/make_computed_style_base.py
+++ b/third_party/WebKit/Source/build/scripts/make_computed_style_base.py
@@ -207,11 +207,12 @@ def _create_diff_groups(fields_to_diff, methods_to_diff, root_group):
if any(field.property_name in (fields_to_diff + field_dependencies) for field in subgroup.all_fields):
diff_group.subgroups.append(_create_diff_groups(fields_to_diff, methods_to_diff, subgroup))
for field in root_group.fields:
- if field.property_name in fields_to_diff:
- diff_group.expressions.append(field.getter_expression)
- for entry in methods_to_diff:
- if field.property_name in entry['field_dependencies']:
- diff_group.expressions.append(entry['method'])
+ if field.is_property:
+ if field.property_name in fields_to_diff:
+ diff_group.expressions.append(field.getter_expression)
+ for entry in methods_to_diff:
+ if field.property_name in entry['field_dependencies']:
+ diff_group.expressions.append(entry['method'])
return diff_group

Powered by Google App Engine
This is Rietveld 408576698