Generate diffs for properties that are generated in ComputedStyle

third_party/WebKit/Source/core/style/ComputedStyle.cpp

 /*
  * Copyright (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
  * reserved.
  * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 543 matching lines @@
   // Animations don't need to be checked either. We always set the new style on
   // the layoutObject, so we will get a chance to fire off the resulting
   // transition properly.
 
   return diff;
 }
 
 bool ComputedStyle::ScrollAnchorDisablingPropertyChanged(
     const ComputedStyle& other,
     const StyleDifference& diff) const {
-  if (GetPosition() != other.GetPosition())
-    return true;
-
   if (ComputedStyleBase::ScrollAnchorDisablingPropertyChanged(other))
     return true;
 
   if (diff.TransformChanged())
     return true;
 
   return false;
 }
 
 bool ComputedStyle::DiffNeedsFullLayoutAndPaintInvalidation(
@@ skipping 138 matching lines @@
             other.rare_inherited_data_->text_stroke_width_)
       return true;
 
     if (!TextShadowDataEquivalent(other))
       return true;
 
     if (!QuotesDataEquivalent(other))
       return true;
   }
 
-  if (inherited_data_->text_autosizing_multiplier_ !=
-      other.inherited_data_->text_autosizing_multiplier_)
-    return true;
-
-  if (inherited_data_->font_.LoadingCustomFonts() !=
-      other.inherited_data_->font_.LoadingCustomFonts())
-    return true;
-
-  if (BoxDirection() != other.BoxDirection() ||
-      RtlOrdering() != other.RtlOrdering() ||
-      GetTextAlign() != other.GetTextAlign() ||
-      TextTransform() != other.TextTransform() ||
-      Direction() != other.Direction() || WhiteSpace() != other.WhiteSpace() ||
-      GetWritingMode() != other.GetWritingMode())
-    return true;
-
-  if (OverflowX() != other.OverflowX() || OverflowY() != other.OverflowY() ||
-      Clear() != other.Clear() || GetUnicodeBidi() != other.GetUnicodeBidi() ||
-      Floating() != other.Floating() ||
-      OriginalDisplay() != other.OriginalDisplay())
-    return true;
-
   if (IsDisplayTableType(Display())) {
     if (BorderCollapse() != other.BorderCollapse() ||
         EmptyCells() != other.EmptyCells() ||
         CaptionSide() != other.CaptionSide() ||
         TableLayout() != other.TableLayout())
       return true;
 
     // In the collapsing border model, 'hidden' suppresses other borders, while
     // 'none' does not, so these style differences can be width differences.
     if ((BorderCollapse() == EBorderCollapse::kCollapse) &&
@@ skipping 17 matching lines @@
   } else if (Display() == EDisplay::kListItem) {
     if (ListStyleType() != other.ListStyleType() ||
         ListStylePosition() != other.ListStylePosition())
       return true;
   }
 
   if ((Visibility() == EVisibility::kCollapse) !=
       (other.Visibility() == EVisibility::kCollapse))
     return true;
 
-  if (HasPseudoStyle(kPseudoIdScrollbar) !=
-      other.HasPseudoStyle(kPseudoIdScrollbar))
-    return true;
-
   // Movement of non-static-positioned object is special cased in
   // ComputedStyle::VisualInvalidationDiff().
 
   return false;
 }
 
 bool ComputedStyle::DiffNeedsFullLayout(const ComputedStyle& other) const {
   if (ComputedStyleBase::DiffNeedsFullLayout(other))
     return true;
 
@@ skipping 42 matching lines @@
         rare_non_inherited_data_->mask_box_image_ !=
             other.rare_non_inherited_data_->mask_box_image_)
       return true;
   }
 
   return false;
 }
 
 bool ComputedStyle::DiffNeedsPaintInvalidationObject(
     const ComputedStyle& other) const {
-  if (Visibility() != other.Visibility() ||
-      PrintColorAdjust() != other.PrintColorAdjust() ||
-      InsideLink() != other.InsideLink() || !BorderVisuallyEqual(other) ||
-      !RadiiEqual(other) || *background_data_ != *other.background_data_)
+  if (ComputedStyleBase::DiffNeedsPaintInvalidationObject(other))
+    return true;
+
+  if (!BorderVisuallyEqual(other) || !RadiiEqual(other) ||
+      *background_data_ != *other.background_data_)
     return true;
 
   if (rare_inherited_data_.Get() != other.rare_inherited_data_.Get()) {
     if (rare_inherited_data_->user_modify_ !=
             other.rare_inherited_data_->user_modify_ ||
         rare_inherited_data_->user_select_ !=
             other.rare_inherited_data_->user_select_ ||
         rare_inherited_data_->image_rendering_ !=
             other.rare_inherited_data_->image_rendering_)
       return true;
@@ skipping 72 matching lines @@
   }
 
   return false;
 }
 
 // This doesn't include conditions needing layout or overflow recomputation
 // which implies visual rect update.
 bool ComputedStyle::DiffNeedsVisualRectUpdate(
     const ComputedStyle& other) const {
   // Visual rect is empty if visibility is hidden.
-  if (Visibility() != other.Visibility())
+  if (ComputedStyleBase::DiffNeedsVisualRectUpdate(other))
     return true;
 
   // Need to update visual rect of the resizer.
   if (Resize() != other.Resize())
     return true;
 
   return false;
 }
 
 void ComputedStyle::UpdatePropertySpecificDifferences(
@@ skipping 1523 matching lines @@
     if (value < 0)
       fvalue -= 0.5f;
     else
       fvalue += 0.5f;
   }
 
   return RoundForImpreciseConversion<int>(fvalue / zoom_factor);
 }
 
 }  // namespace blink