Generate diffs for properties that are generated in ComputedStyle

third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5

 {
   // This file specifies the fields we want to diff in the various diff functions 
   // in ComputedStyle.
 
   parameters: {
     // The name parameter represents the name of the function to be created.
 
     fields_to_diff: {
+      default: [],
     },
 
     // A list of methods to diff (these can be public getters of fields or 
     // functions that use fields to determine a value).
     // Each entry is expressed as a dict of two fields.
     // The fields are method - the method to be diffed and field_dependencies
     // which lists the properties this method depends on.
     methods_to_diff: {
       default: [],
     },
   },
   data: [
     {
         name: "ScrollAnchorDisablingPropertyChanged",
         fields_to_diff: ["width", "min-width", "max-width", "height", "min-height", "max-height", "margin-top", "margin-left", "margin-right", "margin-bottom", 
                   "left", "right", "top", "bottom", "padding-top", 
-                  "padding-left", "padding-right", "padding-bottom"]
+                  "padding-left", "padding-right", "padding-bottom"],
+        methods_to_diff: [
+          {
+            method: "GetPosition()",
+            field_dependencies: ["position"]
+          },
+        ]
     },
     {
         name: "DiffNeedsFullLayoutAndPaintInvalidation",
         fields_to_diff: ["padding-top", "padding-left", "padding-right", 
-                "padding-bottom", "line-height", "font", "-webkit-border-horizontal-spacing", "-webkit-border-vertical-spacing"],
+                "padding-bottom", "line-height", "font", "-webkit-border-horizontal-spacing", "-webkit-border-vertical-spacing", "TextAutosizingMultiplier"],
         methods_to_diff: [
           {
-            method: "BorderLeftWidth()", 
+            method: "BorderLeftWidth()",
             field_dependencies: ["border-left-width"]
           },
           {
             method: "BorderTopWidth()",
             field_dependencies: ["border-top-width"]
           },
           {
             method: "BorderBottomWidth()",
             field_dependencies: ["border-bottom-width"]
           },
           {
             method: "BorderRightWidth()",
             field_dependencies: ["border-right-width"]
-          }
+          },
+          {
+            method: "FontInternal().LoadingCustomFonts()",
+            field_dependencies: ["font"]
+          },
+          {
+            method: "HasPseudoStyle(kPseudoIdScrollbar)",
+            field_dependencies: ["StyleType"]
+          },
+          {
+            method: "BoxDirection()",
+            field_dependencies: ["-webkit-box-direction"]
+          },
+          {
+            method: "RtlOrdering()",
+            field_dependencies: ["-webkit-rtl-ordering"]
+          },
+          {
+            method: "GetTextAlign()",
+            field_dependencies: ["text-align"]
+          },
+          {
+            method: "TextTransform()",
+            field_dependencies: ["text-transform"]
+          },
+          {
+            method: "Direction()",
+            field_dependencies: ["direction"]
+          },
+          {
+            method: "WhiteSpace()",
+            field_dependencies: ["white-space"]
+          },
+          {
+            method: "GetWritingMode()",
+            field_dependencies: ["writing-mode"]
+          },
+          {
+            method: "OverflowX()",
+            field_dependencies: ["overflow-x"]
+          },
+          {
+            method: "OverflowY()",
+            field_dependencies: ["overflow-y"]
+          },
+          {
+            method: "Clear()",
+            field_dependencies: ["clear"]
+          },
+          {
+            method: "GetUnicodeBidi()",
+            field_dependencies: ["unicode-bidi"]
+          },
+          {
+            method: "Floating()",
+            field_dependencies: ["float"]
+          },
+          {
+            method: "OriginalDisplay()",
+            field_dependencies: ["OriginalDisplay"]
+          },

[alancutter (OOO until 2018), 2017/05/24 03:31:17]

Let's sort these alphabetically.

[nainar, 2017/05/24 06:07:21]

We want them sorted in order in which they appeared in the diff function. 

[alancutter (OOO until 2018), 2017/05/24 07:25:36]

Fair point, that's probably important.

         ]
     },
     {
         name: "DiffNeedsFullLayout",
         fields_to_diff: ["width", "min-width", "max-width", "height", "min-height", "max-height", "box-sizing"]
+    },
+    {
+        name: "DiffNeedsPaintInvalidationObject",
+        methods_to_diff: [
+          {
+            method: "Visibility()",
+            field_dependencies: ["visibility"]
+          },
+          {
+            method: "PrintColorAdjust()",
+            field_dependencies: ["-webkit-print-color-adjust"]
+          },
+          {
+            method: "InsideLink()",
+            field_dependencies: ["InsideLink"]
+          }
+        ]
+    },
+    {
+        name: "DiffNeedsVisualRectUpdate",
+        methods_to_diff: [
+          {
+            method: "Visibility()",
+            field_dependencies: ["visibility"]
+          }
+        ]
     }
   ],
 }