Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 { | 1 { |
| 2 // This file specifies the fields we want to diff in the various diff function s | 2 // This file specifies the fields we want to diff in the various diff function s |
| 3 // in ComputedStyle. | 3 // in ComputedStyle. |
| 4 | 4 |
| 5 parameters: { | 5 parameters: { |
| 6 // The name parameter represents the name of the function to be created. | 6 // The name parameter represents the name of the function to be created. |
| 7 | 7 |
| 8 fields_to_diff: { | 8 fields_to_diff: { |
| 9 default: [], | |
| 9 }, | 10 }, |
| 10 | 11 |
| 11 // A list of methods to diff (these can be public getters of fields or | 12 // A list of methods to diff (these can be public getters of fields or |
| 12 // functions that use fields to determine a value). | 13 // functions that use fields to determine a value). |
| 13 // Each entry is expressed as a dict of two fields. | 14 // Each entry is expressed as a dict of two fields. |
| 14 // The fields are method - the method to be diffed and field_dependencies | 15 // The fields are method - the method to be diffed and field_dependencies |
| 15 // which lists the properties this method depends on. | 16 // which lists the properties this method depends on. |
| 16 methods_to_diff: { | 17 methods_to_diff: { |
| 17 default: [], | 18 default: [], |
| 18 }, | 19 }, |
| 19 }, | 20 }, |
| 20 data: [ | 21 data: [ |
| 21 { | 22 { |
| 22 name: "ScrollAnchorDisablingPropertyChanged", | 23 name: "ScrollAnchorDisablingPropertyChanged", |
| 23 fields_to_diff: ["width", "min-width", "max-width", "height", "min-heigh t", "max-height", "margin-top", "margin-left", "margin-right", "margin-bottom", | 24 fields_to_diff: ["width", "min-width", "max-width", "height", "min-heigh t", "max-height", "margin-top", "margin-left", "margin-right", "margin-bottom", |
| 24 "left", "right", "top", "bottom", "padding-top", | 25 "left", "right", "top", "bottom", "padding-top", |
| 25 "padding-left", "padding-right", "padding-bottom"] | 26 "padding-left", "padding-right", "padding-bottom"] |
| 26 }, | 27 }, |
| 27 { | 28 { |
| 28 name: "DiffNeedsFullLayoutAndPaintInvalidation", | 29 name: "DiffNeedsFullLayoutAndPaintInvalidation", |
| 29 fields_to_diff: ["padding-top", "padding-left", "padding-right", | 30 fields_to_diff: ["padding-top", "padding-left", "padding-right", |
| 30 "padding-bottom", "line-height", "font", "-webkit-border-horizon tal-spacing", "-webkit-border-vertical-spacing"], | 31 "padding-bottom", "line-height", "font", "-webkit-border-horizon tal-spacing", "-webkit-border-vertical-spacing", "TextAutosizingMultiplier"], |
| 31 methods_to_diff: [ | 32 methods_to_diff: [ |
| 32 { | 33 { |
| 33 method: "BorderLeftWidth()", | 34 method: "GetPosition()", |
| 35 field_dependencies: ["position"] | |
| 36 }, | |
| 37 { | |
| 38 method: "BorderLeftWidth()", | |
| 34 field_dependencies: ["border-left-width"] | 39 field_dependencies: ["border-left-width"] |
| 35 }, | 40 }, |
| 36 { | 41 { |
| 37 method: "BorderTopWidth()", | 42 method: "BorderTopWidth()", |
| 38 field_dependencies: ["border-top-width"] | 43 field_dependencies: ["border-top-width"] |
| 39 }, | 44 }, |
| 40 { | 45 { |
| 41 method: "BorderBottomWidth()", | 46 method: "BorderBottomWidth()", |
| 42 field_dependencies: ["border-bottom-width"] | 47 field_dependencies: ["border-bottom-width"] |
| 43 }, | 48 }, |
| 44 { | 49 { |
| 45 method: "BorderRightWidth()", | 50 method: "BorderRightWidth()", |
| 46 field_dependencies: ["border-right-width"] | 51 field_dependencies: ["border-right-width"] |
| 47 } | 52 }, |
| 53 { | |
|
shend
2017/05/22 02:48:24
These should be in DiffNeedsFullLayoutAndPaintInva
nainar
2017/05/22 03:12:35
Moved GetPosition() to ScrollAnchorDisablingProper
| |
| 54 method: "FontInternal().LoadingCustomFonts()", | |
| 55 field_dependencies: ["font"] | |
| 56 }, | |
| 57 { | |
| 58 method: "HasPseudoStyle(kPseudoIdScrollbar)", | |
| 59 field_dependencies: ["StyleType"] | |
| 60 }, | |
| 61 { | |
| 62 method: "BoxDirection()", | |
| 63 field_dependencies: ["-webkit-box-direction"] | |
| 64 }, | |
| 65 { | |
| 66 method: "RtlOrdering()", | |
| 67 field_dependencies: ["-webkit-rtl-ordering"] | |
| 68 }, | |
| 69 { | |
| 70 method: "GetTextAlign()", | |
| 71 field_dependencies: ["text-align"] | |
| 72 }, | |
| 73 { | |
| 74 method: "TextTransform()", | |
| 75 field_dependencies: ["text-transform"] | |
| 76 }, | |
| 77 { | |
| 78 method: "Direction()", | |
| 79 field_dependencies: ["direction"] | |
| 80 }, | |
| 81 { | |
| 82 method: "WhiteSpace()", | |
| 83 field_dependencies: ["white-space"] | |
| 84 }, | |
| 85 { | |
| 86 method: "GetWritingMode()", | |
| 87 field_dependencies: ["writing-mode"] | |
| 88 }, | |
| 89 { | |
| 90 method: "OverflowX()", | |
| 91 field_dependencies: ["overflow-x"] | |
| 92 }, | |
| 93 { | |
| 94 method: "OverflowY()", | |
| 95 field_dependencies: ["overflow-y"] | |
| 96 }, | |
| 97 { | |
| 98 method: "Clear()", | |
| 99 field_dependencies: ["clear"] | |
| 100 }, | |
| 101 { | |
| 102 method: "GetUnicodeBidi()", | |
| 103 field_dependencies: ["unicode-bidi"] | |
| 104 }, | |
| 105 { | |
| 106 method: "Floating()", | |
| 107 field_dependencies: ["float"] | |
| 108 }, | |
| 109 { | |
| 110 method: "OriginalDisplay()", | |
| 111 field_dependencies: ["OriginalDisplay"] | |
| 112 }, | |
| 48 ] | 113 ] |
| 49 }, | 114 }, |
| 50 { | 115 { |
| 51 name: "DiffNeedsFullLayout", | 116 name: "DiffNeedsFullLayout", |
| 52 fields_to_diff: ["width", "min-width", "max-width", "height", "min-heigh t", "max-height", "box-sizing"] | 117 fields_to_diff: ["width", "min-width", "max-width", "height", "min-heigh t", "max-height", "box-sizing"] |
| 118 }, | |
| 119 { | |
| 120 name: "DiffNeedsPaintInvalidationObject", | |
| 121 methods_to_diff: [ | |
| 122 { | |
| 123 method: "Visibility()", | |
| 124 field_dependencies: ["visibility"] | |
| 125 }, | |
| 126 { | |
| 127 method: "PrintColorAdjust()", | |
| 128 field_dependencies: ["-webkit-print-color-adjust"] | |
| 129 }, | |
| 130 { | |
| 131 method: "InsideLink()", | |
| 132 field_dependencies: ["InsideLink"] | |
| 133 } | |
| 134 ] | |
| 135 }, | |
| 136 { | |
| 137 name: "DiffNeedsVisualRectUpdate", | |
| 138 methods_to_diff: [ | |
| 139 { | |
| 140 method: "Visibility()", | |
| 141 field_dependencies: ["visibility"] | |
| 142 } | |
| 143 ] | |
| 53 } | 144 } |
| 54 ], | 145 ], |
| 55 } | 146 } |
| OLD | NEW |