LayoutTests/fast/forms/label/detached-document.html - Issue 288933002: Fix crash after detaching document.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/forms/label/detached-document.html

Issue 288933002: Fix crash after detaching document. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added Layout test Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <html>
	ojan 2014/05/22 03:54:45 Is the html element required for this test? If not Is the html element required for this test? If not, we usually leave it out. Also, does putting the <!DOCTYPE html> not work for some reason?
	2 <label id="tCF12">

	3 <script>

	4 tCF3 = tCF12 = document.getElementById("tCF12");

	5 try{tCFDoc2789 = document.implementation.createDocument("", null); tCFDoc2789.ad optNode(tCF3);}catch(e){}

	6 try{var evtCF = document.createEvent('MouseEvent'); evtCF.initMouseEvent("click" , 56644); tCF12.dispatchEvent(evtCF)}catch(e){}
	ojan 2014/05/22 03:54:45 Please minimize this. It makes it easier for peopl Please minimize this. It makes it easier for people who have to understand this test in the future. A few things can be done: 1. Remove duplicate variables. 2. Remove the try/cathhes 3. Move each statement to it's own line. 4. Give the variables less obscure names.
	7 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/forms/label/detached-document-expected.html » ('j') | no next file with comments »