Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10506)

Unified Diff: chrome/installer/util/google_update_settings.cc

Issue 2889323004: Win 10 Inactive toast experiment metrics and storage modifications. (Closed)
Patch Set: Incorporate review comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/google_update_settings.cc
diff --git a/chrome/installer/util/google_update_settings.cc b/chrome/installer/util/google_update_settings.cc
index c1433d5b9f9379c731033bc43f82c6fd80ff3b92..8ff1b60ad72f2b7107f010d5550b23e004f76421 100644
--- a/chrome/installer/util/google_update_settings.cc
+++ b/chrome/installer/util/google_update_settings.cc
@@ -851,11 +851,6 @@ bool GoogleUpdateSettings::GetUpdateDetail(ProductData* data) {
bool GoogleUpdateSettings::SetExperimentLabels(
bool system_install,
const base::string16& experiment_labels) {
- // There is nothing to do if this brand does not support integration with
grt (UTC plus 2) 2017/05/31 12:24:10 please update GoogleUpdateSettingsTest so that it
nikunjb 2017/06/02 05:11:24 Done. (New CL for this https://codereview.chromium
- // Google Update.
- if (!install_static::kUseGoogleUpdateIntegration)
- return false;
-
HKEY reg_root = system_install ? HKEY_LOCAL_MACHINE : HKEY_CURRENT_USER;
// Use the browser distribution and install level to write to the correct
@@ -885,11 +880,6 @@ bool GoogleUpdateSettings::SetExperimentLabels(
bool GoogleUpdateSettings::ReadExperimentLabels(
bool system_install,
base::string16* experiment_labels) {
- // There is nothing to do if this brand does not support integration with
- // Google Update.
- if (!install_static::kUseGoogleUpdateIntegration)
- return false;
-
HKEY reg_root = system_install ? HKEY_LOCAL_MACHINE : HKEY_CURRENT_USER;
BrowserDistribution* dist = BrowserDistribution::GetDistribution();
base::string16 client_state_path(
« chrome/installer/util/experiment_unittest.cc ('K') | « chrome/installer/util/experiment_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698