Win 10 Inactive toast experiment metrics and storage modifications.

chrome/installer/util/experiment.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/installer/util/experiment.h"
+
+#include <algorithm>
+#include <cmath>
+
+#include "base/logging.h"
+
+namespace installer {
+
+namespace {
+// Returns closest integer of logarithm of |x| with base |b|.

[grt (UTC plus 2), 2017/06/02 11:30:46]

nit: blank line before comment

[nikunjb, 2017/06/02 22:49:48]

Done.

+double LogFloor(double x, double b) {
+  return std::round(std::log(x) / std::log(b));
+}
+
+// Returns the base to use for exponential buckets so that buckets
+// 0,1,.. 2^|bits|-1 cover range [0, max_val]. If this function return b
+// then Bucket value i will store values from [b^i, b^(i+1)]
+double ExpBucketBase(int max_val, int bits) {
+  return std::exp(std::log(max_val + 1) / ((1 << bits) - 1));
+}
+
+// Invert bucket to the approximate value that the bucket may correspond to.
+int BucketToValue(int bucket, double bucket_base) {

[grt (UTC plus 2), 2017/06/02 11:30:45]

unused

[nikunjb, 2017/06/02 22:49:48]

Done.

+  return static_cast<int>(std::round(std::pow(bucket_base, bucket) - 1));
+}
+
+}  // namespace
+
+Experiment::Experiment() = default;
+Experiment::Experiment(Experiment&&) = default;
+Experiment::Experiment(const Experiment&) = default;
+Experiment::~Experiment() = default;
+
+void Experiment::InitializeFromMetrics(const ExperimentMetrics& metrics) {
+  *this = Experiment();
+  DCHECK_NE(ExperimentMetrics::kUninitialized, metrics.state);
+  DCHECK(metrics.InInitialState() ||
+         metrics.state == ExperimentMetrics::kGroupAssigned);
+  metrics_ = metrics;
+  state_ = metrics.state;
+  group_ = metrics.group;
+}
+
+void Experiment::SetState(ExperimentMetrics::State state) {
+  DCHECK_NE(ExperimentMetrics::kUninitialized, state);
+  state_ = state;
+  metrics_.state = state;
+}
+
+void Experiment::AssignGroup(int group) {
+  DCHECK_GE(group, 0);
+  DCHECK_LT(group, ExperimentMetrics::kNumGroups);
+  DCHECK(metrics_.InInitialState());
+
+  group_ = group;
+  metrics_.group = group;
+  SetState(ExperimentMetrics::kGroupAssigned);
+}
+
+void Experiment::SetToastLocation(ExperimentMetrics::ToastLocation location) {
+  DCHECK(!metrics_.InTerminalState());
+  DCHECK(!metrics_.InInitialState());
+  toast_location_ = location;
+  metrics_.toast_location = location;
+}
+
+void Experiment::SetInactiveDays(int days) {
+  DCHECK(!metrics_.InTerminalState());
+  DCHECK(!metrics_.InInitialState());
+  DCHECK_GE(days, 0);
+  inactive_days_ = days;
+  double log_base = ExpBucketBase(ExperimentMetrics::kMaxLastUsed,
+                                  ExperimentMetrics::kLastUsedBucketBits);
+  metrics_.last_used_bucket =
+      LogFloor(1 + std::min(days, ExperimentMetrics::kMaxLastUsed), log_base);
+}
+
+void Experiment::SetToastCount(int count) {
+  DCHECK(!metrics_.InTerminalState());
+  DCHECK(!metrics_.InInitialState());
+  toast_count_ = count;
+  metrics_.toast_count = std::min(count, ExperimentMetrics::kMaxToastCount);
+}
+
+void Experiment::SetDisplayTime(base::Time time) {
+  DCHECK(!metrics_.InTerminalState());
+  DCHECK(!metrics_.InInitialState());
+  if (metrics_.first_toast_offset == 0) {
+    // This is the first time toast is shown so add user to today's cohort.
+    first_display_time_ = time;
+    metrics_.first_toast_offset =
+        (time - base::Time::UnixEpoch() -
+         base::TimeDelta::FromSeconds(
+             ExperimentMetrics::kExperimentStartSeconds))
+            .InDays();
+    // If display time is outside the experiment range (possible due to
+    // invalid local time), then set it to be kMaxFirstToastOffset.
+    metrics_.first_toast_offset = std::min(

[grt (UTC plus 2), 2017/06/02 11:30:45]

nit: reverse these since the std::min isn't needed if the offset is < 0
    if (metrics_.first_toast_offset < 0) {
      metrics_.first_toast_offset = ExperimentMetrics::kMaxFirstToastOffset;
    } else {
      metrics_.first_toast_offset = std::min(...);
    }

[nikunjb, 2017/06/02 22:49:48]

Done.

+        metrics_.first_toast_offset, ExperimentMetrics::kMaxFirstToastOffset);
+    if (metrics_.first_toast_offset < 0) {
+      metrics_.first_toast_offset = ExperimentMetrics::kMaxFirstToastOffset;
+    }
+    metrics_.toast_hour = (time - time.LocalMidnight()).InHours();

[grt (UTC plus 2), 2017/06/02 11:30:46]

do we want this only for the first toast rather than the latest one?

[nikunjb, 2017/06/02 22:49:48]

I was actually not sure, My reasoning for only doing it with first was that
since metrics_ doesn't currently use latest_display_time, toast_hour will be
more consistent with what is seen in metrics.

Although since for this experiment if we are not going to retoast a user it
makes sense to move this outside.

+  }
+  latest_display_time_ = time;
+  DCHECK_LE(metrics_.toast_hour, 24);
+  DCHECK_GE(metrics_.toast_hour, 0);
+}
+
+void Experiment::SetUserSessionUptime(base::TimeDelta time_delta) {
+  DCHECK(!metrics_.InTerminalState());
+  DCHECK(!metrics_.InInitialState());
+  user_session_uptime_ = time_delta;
+  double log_base = ExpBucketBase(ExperimentMetrics::kMaxSessionLength,
+                                  ExperimentMetrics::kSessionLengthBucketBits);
+  metrics_.session_length_bucket = LogFloor(
+      1 + std::min(time_delta, base::TimeDelta::FromMinutes(
+                                   ExperimentMetrics::kMaxSessionLength))
+              .InMinutes(),
+      log_base);
+}
+
+void Experiment::SetActionDelay(base::TimeDelta time_delta) {
+  DCHECK(!metrics_.InTerminalState());
+  DCHECK(!metrics_.InInitialState());
+  action_delay_ = time_delta;
+  double log_base = ExpBucketBase(ExperimentMetrics::kMaxActionDelay,
+                                  ExperimentMetrics::kActionDelayBucketBits);
+  metrics_.action_delay_bucket =
+      LogFloor(1 + std::min(time_delta, base::TimeDelta::FromSeconds(
+                                            ExperimentMetrics::kMaxActionDelay))
+                       .InSeconds(),
+               log_base);
+}
+
+}  // namespace installer