Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2889323002: [DEMO CL - not for landing] Change height property's group from box to naina (Closed)

Created:
3 years, 7 months ago by nainar
Modified:
3 years, 7 months ago
Reviewers:
shend
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DEMO CL - not for landing] Change height property's group from box to naina Diff: https://gist.github.com/7bacceaa25f98421cc14a4b4db5f5eac/revisions

Patch Set 1 #

Patch Set 2 : Assert for correct size #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (10 generated)
nainar
Description was changed from ========== [DEMO CL - not for landing] Change height property's group ...
3 years, 7 months ago (2017-05-19 01:21:22 UTC) #1
shend
The CQ bit was checked by shend@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-19 05:06:38 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889323002/1
3 years, 7 months ago (2017-05-19 05:07:06 UTC) #3
shend
The CQ bit was unchecked by shend@chromium.org
3 years, 7 months ago (2017-05-19 05:33:20 UTC) #4
nainar
The CQ bit was checked by nainar@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-19 05:39:56 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2889323002/20001
3 years, 7 months ago (2017-05-19 05:40:33 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-19 07:57:48 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/458080)
3 years, 7 months ago (2017-05-19 07:57:48 UTC) #8
nainar
The CQ bit was checked by nainar@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-22 00:01:54 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 00:02:02 UTC) #10

Powered by Google App Engine
This is Rietveld 408576698