Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 2889253002: Ship dart2js output for dev_compiler/web in the sdk. (Closed)

Created:
3 years, 7 months ago by Jacob
Modified:
3 years, 7 months ago
Reviewers:
vsm, zra, rmacnak
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ship dart2js output for dev_compiler/web in the sdk. These tools are used to support applying source maps to stack traces and running the Dart dev compiler in the browser as part of an extension. This CL adds the following files dart-sdk/lib/dev_compiler/web/ddc_web_compiler.js dart-sdk/lib/dev_compiler/web/dart_stack_trace_mapper BUG= R=rmacnak@google.com, vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/728f71f740c8e920eb2abcf29ef20f9670feeaa7

Patch Set 1 #

Total comments: 2

Patch Set 2 : Ship dart2js output for dev_compiler/web in the sdk. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -0 lines) Patch
M sdk/BUILD.gn View 1 chunk +16 lines, -0 lines 2 comments Download
M utils/dartdevc/BUILD.gn View 1 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Jacob
Take #2. As vsm pointed out, I could just use dart2js and .packages files to ...
3 years, 7 months ago (2017-05-18 20:57:42 UTC) #2
vsm
lgtm https://codereview.chromium.org/2889253002/diff/1/utils/dartdevc/BUILD.gn File utils/dartdevc/BUILD.gn (right): https://codereview.chromium.org/2889253002/diff/1/utils/dartdevc/BUILD.gn#newcode36 utils/dartdevc/BUILD.gn:36: [ "absolute", rebase_path("../../pkg/dev_compiler") ], nit: line len
3 years, 7 months ago (2017-05-18 21:01:46 UTC) #3
Jacob
https://codereview.chromium.org/2889253002/diff/1/utils/dartdevc/BUILD.gn File utils/dartdevc/BUILD.gn (right): https://codereview.chromium.org/2889253002/diff/1/utils/dartdevc/BUILD.gn#newcode36 utils/dartdevc/BUILD.gn:36: [ "absolute", rebase_path("../../pkg/dev_compiler") ], On 2017/05/18 21:01:46, vsm wrote: ...
3 years, 7 months ago (2017-05-18 21:06:45 UTC) #4
rmacnak
lgtm
3 years, 7 months ago (2017-05-18 23:46:24 UTC) #5
Jacob
Committed patchset #2 (id:20001) manually as 728f71f740c8e920eb2abcf29ef20f9670feeaa7 (presubmit successful).
3 years, 7 months ago (2017-05-19 20:21:59 UTC) #7
zra
https://codereview.chromium.org/2889253002/diff/20001/sdk/BUILD.gn File sdk/BUILD.gn (right): https://codereview.chromium.org/2889253002/diff/20001/sdk/BUILD.gn#newcode391 sdk/BUILD.gn:391: copy("copy_dev_compiler_tools") { This doesn't appear to be hooked up ...
3 years, 7 months ago (2017-05-20 21:43:30 UTC) #9
zra
3 years, 7 months ago (2017-05-21 04:45:35 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/2889253002/diff/20001/sdk/BUILD.gn
File sdk/BUILD.gn (right):

https://codereview.chromium.org/2889253002/diff/20001/sdk/BUILD.gn#newcode391
sdk/BUILD.gn:391: copy("copy_dev_compiler_tools") {
On 2017/05/20 21:43:30, zra wrote:
> This doesn't appear to be hooked up to anything. Could you explain how this
> target is intended to be used?

Also, including this in an ARM cross-build of the SDK increases build time from
~5 minutes to >30 minutes. That is probably too long.

Powered by Google App Engine
This is Rietveld 408576698