content/renderer/p2p/ipc_socket_factory.cc - Issue 288923014: Send SignalClose to the clients of P2PSocket, if TCP socket is failed to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/p2p/ipc_socket_factory.cc

Issue 288923014: Send SignalClose to the clients of P2PSocket, if TCP socket is failed to (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/p2p/ipc_socket_factory.cc

diff --git a/content/renderer/p2p/ipc_socket_factory.cc b/content/renderer/p2p/ipc_socket_factory.cc

index 59d94ff6837c0f04ff221ef1b51044d0a1f1bb17..d0354943491a691c0bed4ccc59a8d73b5e20ce26 100644

--- a/content/renderer/p2p/ipc_socket_factory.cc

+++ b/content/renderer/p2p/ipc_socket_factory.cc

@@ -474,8 +474,12 @@ void IpcPacketSocket::OnSendComplete() {

void IpcPacketSocket::OnError() {

DCHECK_EQ(base::MessageLoop::current(), message_loop_);

+ bool was_closed = (state_ == IS_ERROR || state_ == IS_CLOSED);

state_ = IS_ERROR;

error_ = ECONNABORTED;

+ if (!was_closed) {

+ SignalClose(this, 0);

+ }

}

void IpcPacketSocket::OnDataReceived(const net::IPEndPoint& address,

« no previous file with comments | « no previous file | no next file » | no next file with comments »