Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 288923006: hack to expand 'pad' to account for very wide glyphs (Closed)

Created:
6 years, 7 months ago by reed1
Modified:
6 years, 7 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

hack to expand 'pad' to account for very wide glyphs BUG=crbug.com/373785 Committed: http://code.google.com/p/skia/source/detail?r=14755

Patch Set 1 #

Patch Set 2 : apply hack to drawPosText and drawPosTextH #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M src/core/SkBBoxRecord.cpp View 1 3 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
reed1
6 years, 7 months ago (2014-05-15 20:14:53 UTC) #1
robertphillips
yuck but lgtm
6 years, 7 months ago (2014-05-15 20:26:08 UTC) #2
mtklein
On 2014/05/15 20:26:08, robertphillips wrote: > yuck but lgtm ditto
6 years, 7 months ago (2014-05-15 20:26:27 UTC) #3
mtklein
lgtm
6 years, 7 months ago (2014-05-15 20:37:01 UTC) #4
reed1
The CQ bit was checked by reed@google.com
6 years, 7 months ago (2014-05-15 20:37:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/288923006/20001
6 years, 7 months ago (2014-05-15 20:37:19 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 20:48:55 UTC) #7
Message was sent while issue was closed. 
Change committed as 14755

Powered by Google App Engine
This is Rietveld 408576698