Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: chromeos/network/shill_property_handler.cc

Issue 288923005: Improve logging of Devices and Technologies (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/shill_property_handler.cc
diff --git a/chromeos/network/shill_property_handler.cc b/chromeos/network/shill_property_handler.cc
index 13f34c1072515595caa02f25e9296d97f1ea9067..93983c296cf50700b5927c1327c2d7b8212c9bf3 100644
--- a/chromeos/network/shill_property_handler.cc
+++ b/chromeos/network/shill_property_handler.cc
@@ -4,6 +4,8 @@
#include "chromeos/network/shill_property_handler.h"
+#include <sstream>
+
#include "base/bind.h"
#include "base/format_macros.h"
#include "base/stl_util.h"
@@ -406,9 +408,10 @@ void ShillPropertyHandler::UpdateObserved(ManagedState::ManagedType type,
void ShillPropertyHandler::UpdateAvailableTechnologies(
const base::ListValue& technologies) {
+ std::stringstream technologies_str;
+ technologies_str << technologies;
+ NET_LOG_EVENT("AvailableTechnologies:", technologies_str.str());
available_technologies_.clear();
- NET_LOG_EVENT("AvailableTechnologiesChanged",
- base::StringPrintf("Size: %" PRIuS, technologies.GetSize()));
for (base::ListValue::const_iterator iter = technologies.begin();
iter != technologies.end(); ++iter) {
std::string technology;
@@ -421,9 +424,10 @@ void ShillPropertyHandler::UpdateAvailableTechnologies(
void ShillPropertyHandler::UpdateEnabledTechnologies(
const base::ListValue& technologies) {
+ std::stringstream technologies_str;
+ technologies_str << technologies;
+ NET_LOG_EVENT("EnabledTechnologies:", technologies_str.str());
enabled_technologies_.clear();
- NET_LOG_EVENT("EnabledTechnologiesChanged",
- base::StringPrintf("Size: %" PRIuS, technologies.GetSize()));
for (base::ListValue::const_iterator iter = technologies.begin();
iter != technologies.end(); ++iter) {
std::string technology;
@@ -437,9 +441,10 @@ void ShillPropertyHandler::UpdateEnabledTechnologies(
void ShillPropertyHandler::UpdateUninitializedTechnologies(
const base::ListValue& technologies) {
+ std::stringstream technologies_str;
+ technologies_str << technologies;
+ NET_LOG_EVENT("UninitializedTechnologies:", technologies_str.str());
uninitialized_technologies_.clear();
- NET_LOG_EVENT("UninitializedTechnologiesChanged",
- base::StringPrintf("Size: %" PRIuS, technologies.GetSize()));
for (base::ListValue::const_iterator iter = technologies.begin();
iter != technologies.end(); ++iter) {
std::string technology;
« chromeos/network/network_state_handler.cc ('K') | « chromeos/network/network_state_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698