Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Unified Diff: chrome/browser/extensions/settings_api_helpers.h

Issue 288923004: Add an extension override bubble and warning box for proxy extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address review comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/settings_api_helpers.h
diff --git a/chrome/browser/extensions/settings_api_helpers.h b/chrome/browser/extensions/settings_api_helpers.h
index db2ba36022a0ba95715c036f5336cfac6ef1e035..12a55f8a5e4e5336c8a9e1ca18cf6d9d811dea8f 100644
--- a/chrome/browser/extensions/settings_api_helpers.h
+++ b/chrome/browser/extensions/settings_api_helpers.h
@@ -26,23 +26,29 @@ const extensions::SettingsOverrides* FindOverridingExtension(
// Returns which extension is overriding the homepage in a given
// |browser_context|. |home_page_url|, if non-NULL, will contain the home_page
// value the extension has set.
-const Extension* OverridesHomepage(content::BrowserContext* browser_context,
- GURL* home_page_url);
+const Extension* GetExtensionOverridingHomepage(
+ content::BrowserContext* browser_context,
+ GURL* home_page_url);
// Returns which extension is overriding the homepage in a given
// |browser_context|. |startup_pages|, if non-NULL, will contain the vector of
// startup page URLs the extension has set.
-const Extension* OverridesStartupPages(content::BrowserContext* browser_context,
- std::vector<GURL>* startup_pages);
+const Extension* GetExtensionOverridingStartupPages(
+ content::BrowserContext* browser_context,
+ std::vector<GURL>* startup_pages);
// Returns which extension is overriding the search engine in a given
// |browser_context|. |search_provider|, if non-NULL, will contain the search
// provider the extension has set.
-const Extension* OverridesSearchEngine(
+const Extension* GetExtensionOverridingSearchEngine(
content::BrowserContext* browser_context,
api::manifest_types::ChromeSettingsOverrides::Search_provider*
search_provider);
+// Returns which extension is overriding the proxy in a given |browser_context|.
Devlin 2014/05/21 17:00:39 nit: Even though we should probably know it, pleas
+const Extension* GetExtensionOverridingProxy(
+ content::BrowserContext* browser_context);
+
} // namespace extensions
#endif // CHROME_BROWSER_EXTENSIONS_SETTINGS_API_HELPERS_H_

Powered by Google App Engine
This is Rietveld 408576698