Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: chrome/browser/ui/webui/options/browser_options_handler.cc

Issue 288923004: Add an extension override bubble and warning box for proxy extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/browser_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/browser_options_handler.cc b/chrome/browser/ui/webui/options/browser_options_handler.cc
index 0f264945a360f3cb03409c74c1aecdc49587eb5a..a679479651a122ebe0754fb0b58792cd71ab5590 100644
--- a/chrome/browser/ui/webui/options/browser_options_handler.cc
+++ b/chrome/browser/ui/webui/options/browser_options_handler.cc
@@ -295,7 +295,6 @@ void BrowserOptionsHandler::GetLocalizedValues(base::DictionaryValue* values) {
#if defined(ENABLE_SETTINGS_APP)
{ "profilesAppListSwitch", IDS_SETTINGS_APP_PROFILES_SWITCH_BUTTON_LABEL },
#endif
- { "proxiesLabelExtension", IDS_OPTIONS_EXTENSION_PROXIES_LABEL },
{ "proxiesLabelSystem", IDS_OPTIONS_SYSTEM_PROXIES_LABEL,
IDS_PRODUCT_NAME },
{ "resetProfileSettings", IDS_RESET_PROFILE_SETTINGS_BUTTON },
@@ -310,6 +309,7 @@ void BrowserOptionsHandler::GetLocalizedValues(base::DictionaryValue* values) {
{ "sectionTitleAppearance", IDS_APPEARANCE_GROUP_NAME },
{ "sectionTitleDefaultBrowser", IDS_OPTIONS_DEFAULTBROWSER_GROUP_NAME },
{ "sectionTitleUsers", IDS_PROFILES_OPTIONS_GROUP_NAME },
+ { "sectionTitleProxy", IDS_OPTIONS_PROXY_GROUP_NAME },
{ "sectionTitleSearch", IDS_OPTIONS_DEFAULTSEARCH_GROUP_NAME },
{ "sectionTitleStartup", IDS_OPTIONS_STARTUP_GROUP_NAME },
{ "sectionTitleSync", IDS_SYNC_OPTIONS_GROUP_NAME },
@@ -1713,6 +1713,10 @@ void BrowserOptionsHandler::SetupProxySettingsSection() {
web_ui()->CallJavascriptFunction("BrowserOptions.setupProxySettingsSection",
disabled, extension_controlled);
+#if defined(OS_WIN)
+ SetupExtensionControlledIndicators();
+#endif // defined(OS_WIN)
+
#endif // !defined(OS_CHROMEOS)
}
@@ -1782,6 +1786,11 @@ void BrowserOptionsHandler::SetupExtensionControlledIndicators() {
}
AppendExtensionData("newTabPage", extension, &extension_controlled);
+ // Check if an extension is overwriting the proxy setting.
+ extension = extensions::OverridesProxy(
+ Profile::FromWebUI(web_ui()));
+ AppendExtensionData("proxy", extension, &extension_controlled);
+
web_ui()->CallJavascriptFunction("BrowserOptions.toggleExtensionIndicators",
extension_controlled);
#endif // defined(OS_WIN)

Powered by Google App Engine
This is Rietveld 408576698