Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: chrome/browser/extensions/proxy_overridden_bubble_controller.h

Issue 288923004: Add an extension override bubble and warning box for proxy extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address UI team comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_EXTENSIONS_PROXY_OVERRIDDEN_BUBBLE_CONTROLLER_H_
6 #define CHROME_BROWSER_EXTENSIONS_PROXY_OVERRIDDEN_BUBBLE_CONTROLLER_H_
7
8 #include <string>
9
Devlin 2014/06/05 17:16:31 nit: #include "base/macros.h" (for DISALLOW_COPY_A
10 #include "chrome/browser/extensions/extension_message_bubble_controller.h"
11
Devlin 2014/06/05 17:16:31 nit: forward declare class Profile.
12 namespace extensions {
13
14 class ProxyOverriddenBubbleController
15 : public ExtensionMessageBubbleController {
16 public:
17 explicit ProxyOverriddenBubbleController(Profile* profile);
18 virtual ~ProxyOverriddenBubbleController();
19
20 // Whether the controller knows that we should show the bubble for extension
21 // with |extension_id|. Returns true if so.
22 bool ShouldShow(const std::string& extension_id);
23
24 // ExtensionMessageBubbleController:
25 virtual bool CloseOnDeactivate() OVERRIDE;
26
27 private:
28 // A weak pointer to the profile we are associated with. Not owned by us.
29 Profile* profile_;
30
31 DISALLOW_COPY_AND_ASSIGN(ProxyOverriddenBubbleController);
32 };
33
34 } // namespace extensions
35
36 #endif // CHROME_BROWSER_EXTENSIONS_PROXY_OVERRIDDEN_BUBBLE_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698