Add an extension override bubble and warning box for proxy extensions.

extensions/browser/extension_prefs.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_EXTENSION_PREFS_H_
 #define EXTENSIONS_BROWSER_EXTENSION_PREFS_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 313 matching lines @@
   bool HasSettingsApiBubbleBeenAcknowledged(const std::string& extension_id);
   void SetSettingsApiBubbleBeenAcknowledged(const std::string& extension_id,
                                             bool value);
 
   // Whether the user has been notified about extension with |extension_id|
   // overriding the new tab page.
   bool HasNtpOverriddenBubbleBeenAcknowledged(const std::string& extension_id);
   void SetNtpOverriddenBubbleBeenAcknowledged(const std::string& extension_id,
                                               bool value);
 
+  // Whether the user has been notified about extension with |extension_id|
+  // overriding the proxy.
+  bool HasProxyOverriddenBubbleBeenAcknowledged(

[Devlin, 2014/05/20 17:26:31]

There was an effort awhile back to try and make ExtensionPrefs an abstract
storage area, rather than know about every individual thing.  Seeing all these
Has*BeenAcknowledged() and Set*Acknowledged() reminds me of why.  I think, at
some point, it'd be nicer to see the callers just use ReadPrefAsBoolean() and
UpdateExtensionPref(), since they're really not any longer and it reduces
clutter in ExtensionPrefs.  (There's also the concern of knowledge layering
violations - even though there are no illegal includes, I don't think top-level
/extensions should know about things like ProxyOverride bubbles, which are
inherently chrome-y.)

That said, that would be a larger change (since there are all the others, too),
so it shouldn't block this CL.  But, for the future. :)

[Finnur, 2014/05/21 16:30:32]

Yeah, I've been pondering something along the same lines. Maybe I'll go back and
clean this up in a separate CL.

+      const std::string& extension_id);
+  void SetProxyOverriddenBubbleBeenAcknowledged(const std::string& extension_id,
+                                                bool value);
+
   // Returns true if the extension notification code has already run for the
   // first time for this profile. Currently we use this flag to mean that any
   // extensions that would trigger notifications should get silently
   // acknowledged. This is a fuse. Calling it the first time returns false.
   // Subsequent calls return true. It's not possible through an API to ever
   // reset it. Don't call it unless you mean it!
   bool SetAlertSystemFirstRun();
 
   // Checks if extensions are blacklisted by default, by policy.
   // The ManagementPolicy::Provider methods also take this into account, and
@@ skipping 371 matching lines @@
   bool extensions_disabled_;
 
   ObserverList<ExtensionPrefsObserver> observer_list_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionPrefs);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_EXTENSION_PREFS_H_