Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: ios/chrome/browser/web/mailto_url_rewriter.mm

Issue 2889183005: Show all mailto: handlers, but dim unavailable ones. (Closed)
Patch Set: fixed BUILD.gn and unit tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/web/fake_mailto_handler_helpers.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/web/mailto_url_rewriter.mm
diff --git a/ios/chrome/browser/web/mailto_url_rewriter.mm b/ios/chrome/browser/web/mailto_url_rewriter.mm
index 5bb6b26f089792357cd5cd9970c096d2100420f4..e264b91c5f4573e0f67f54d340a2a5180f2ffd32 100644
--- a/ios/chrome/browser/web/mailto_url_rewriter.mm
+++ b/ios/chrome/browser/web/mailto_url_rewriter.mm
@@ -113,7 +113,7 @@ NSString* const kMailtoDefaultHandlerKey = @"MailtoHandlerDefault";
NSString* value = [self defaultHandlerID];
if ([value length]) {
MailtoHandler* handler = _handlers[value];
- if (handler) {
+ if ([handler isAvailable]) {
return [handler rewriteMailtoURL:gURL];
}
}
@@ -129,8 +129,7 @@ NSString* const kMailtoDefaultHandlerKey = @"MailtoHandlerDefault";
- (void)addMailtoApps:(NSArray<MailtoHandler*>*)handlerApps {
for (MailtoHandler* app in handlerApps) {
- if ([app isAvailable])
- [_handlers setObject:app forKey:[app appStoreID]];
+ [_handlers setObject:app forKey:[app appStoreID]];
}
[self migrateLegacyOptions];
[self autoDefaultToGmailIfInstalled];
« no previous file with comments | « ios/chrome/browser/web/fake_mailto_handler_helpers.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698