ios/chrome/browser/ui/settings/content_settings_collection_view_controller_unittest.mm - Issue 2889183005: Show all mailto: handlers, but dim unavailable ones.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/settings/content_settings_collection_view_controller_unittest.mm

Issue 2889183005: Show all mailto: handlers, but dim unavailable ones. (Closed)

Patch Set: add deps Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ios/chrome/browser/ui/settings/compose_email_handler_collection_view_controller.mm ('K') | « ios/chrome/browser/ui/settings/content_settings_collection_view_controller.mm ('k') | ios/chrome/browser/web/fake_mailto_handler_helpers.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/settings/content_settings_collection_view_controller_unittest.mm

diff --git a/ios/chrome/browser/ui/settings/content_settings_collection_view_controller_unittest.mm b/ios/chrome/browser/ui/settings/content_settings_collection_view_controller_unittest.mm

index b665cb270e0de289769cbebac13b6f436920a7dc..9a68fe64afeffd613bd19510c06bc0d649cf7081 100644

--- a/ios/chrome/browser/ui/settings/content_settings_collection_view_controller_unittest.mm

+++ b/ios/chrome/browser/ui/settings/content_settings_collection_view_controller_unittest.mm

@@ -44,14 +44,9 @@ TEST_F(ContentSettingsCollectionViewControllerTest, TestModel) {

CheckTitleWithId(IDS_IOS_CONTENT_SETTINGS_TITLE);

ASSERT_EQ(1, NumberOfSections());

- // Compose Email section is shown only if experiment is turned on and

- // there are enough number of available mailto: URL handlers.

- int number_of_handlers =

- [[[[MailtoURLRewriter alloc] initWithStandardHandlers] defaultHandlers]

- count];

+ // Compose Email section is shown only if experiment is turned on.

bool show_compose_email_section =

- experimental_flags::IsNativeAppLauncherEnabled() &&

- number_of_handlers > 1;

+ !experimental_flags::IsNativeAppLauncherEnabled();

pkl (ping after 24h if needed) 2017/05/19 18:22:03 Note that there was a bug which was masked by the

int expectedNumberOfItems = show_compose_email_section ? 3 : 2;

EXPECT_EQ(expectedNumberOfItems, NumberOfItemsInSection(0));

CheckDetailItemTextWithIds(IDS_IOS_BLOCK_POPUPS, IDS_IOS_SETTING_ON, 0, 0);