Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/sync/base/model_type.h

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/test/values_test_util.h ('K') | « components/signin/core/browser/about_signin_internals.cc ('k') | components/sync/driver/about_sync_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/base/model_type.h
diff --git a/components/sync/base/model_type.h b/components/sync/base/model_type.h
index eb8365323f7beb9a8e4f57afde54870ea2e6b010..05bfca893cf3a60cd619d6b75b2d5fe94df34e13 100644
--- a/components/sync/base/model_type.h
+++ b/components/sync/base/model_type.h
@@ -286,8 +286,7 @@ int ModelTypeToHistogramInt(ModelType model_type);
// Handles all model types, and not just real ones.
//
-// Caller takes ownership of returned value.
-base::Value* ModelTypeToValue(ModelType model_type);
+std::unique_ptr<base::Value> ModelTypeToValue(ModelType model_type);
// Converts a Value into a ModelType - complement to ModelTypeToValue().
ModelType ModelTypeFromValue(const base::Value& value);
« base/test/values_test_util.h ('K') | « components/signin/core/browser/about_signin_internals.cc ('k') | components/sync/driver/about_sync_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698