Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Side by Side Diff: components/sync/engine/events/protocol_event.cc

Issue 2889163002: Remove raw DictionaryValue::Set in //components (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/sync/engine/events/protocol_event.h" 5 #include "components/sync/engine/events/protocol_event.h"
6 6
7 #include "base/memory/ptr_util.h"
8
7 namespace syncer { 9 namespace syncer {
8 10
9 ProtocolEvent::ProtocolEvent() {} 11 ProtocolEvent::ProtocolEvent() {}
10 12
11 ProtocolEvent::~ProtocolEvent() {} 13 ProtocolEvent::~ProtocolEvent() {}
12 14
13 std::unique_ptr<base::DictionaryValue> ProtocolEvent::ToValue( 15 std::unique_ptr<base::DictionaryValue> ProtocolEvent::ToValue(
14 const ProtocolEvent& event) { 16 const ProtocolEvent& event) {
15 std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue()); 17 auto dict = base::MakeUnique<base::DictionaryValue>();
16 18
17 dict->SetDouble("time", event.GetTimestamp().ToJsTime()); 19 dict->SetDouble("time", event.GetTimestamp().ToJsTime());
18 dict->SetString("type", event.GetType()); 20 dict->SetString("type", event.GetType());
19 dict->SetString("details", event.GetDetails()); 21 dict->SetString("details", event.GetDetails());
20 dict->Set("proto", event.GetProtoMessage().release()); 22 dict->Set("proto", event.GetProtoMessage());
21 23
22 return dict; 24 return dict;
23 } 25 }
24 26
25 } // namespace syncer 27 } // namespace syncer
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698