third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.request-end-to-end.html - Issue 2889153004: Upstream service worker "request" tests to WPT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.request-end-to-end.html

Issue 2889153004: Upstream service worker "request" tests to WPT (Closed)

Patch Set: Add "use strict" directive Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/request-end-to-end-worker.js ('k') | third_party/WebKit/LayoutTests/http/tests/serviceworker/request-body-blob.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.request-end-to-end.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/request-end-to-end.html b/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.request-end-to-end.html

similarity index 73%

rename from third_party/WebKit/LayoutTests/http/tests/serviceworker/request-end-to-end.html

rename to third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.request-end-to-end.html

index 9b7c91645316a523a98e9f0ff0af6c65e2775fd1..04fa30b5422003fb42a8f8677cce2b55096e0a91 100644

--- a/third_party/WebKit/LayoutTests/http/tests/serviceworker/request-end-to-end.html

+++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.request-end-to-end.html

@@ -1,9 +1,16 @@

<!DOCTYPE html>

+<!-- This test is prefixed with `chromium.` because the equivalent version

+ available in Web Platform Tests contains additional assertions which Chromium

+ currently fails. This test should be persisted only to preserve test coverage

+ until such time as the upstream version can be made to pass. See

+ https://crbug.com/595993 -->

<title>Service Worker: FetchEvent.request passed to onfetch</title>

+'use strict';

promise_test(t => {

var url = 'resources/request-end-to-end-worker.js';

var scope = 'resources/blank.html';

@@ -27,6 +34,11 @@ promise_test(t => {

'TypeError.')

assert_equals(result.credentials, 'include', 'request.credentials');

assert_equals(result.redirect, 'manual', 'request.redirect');

+ // TODO(falken): Chromium should fail this assertion but currently

+ // passes it. The equivalent WPT test instead asserts:

+ // assert_equals(result.headers['user-agent'], undefined);

+ // Once Chromium passes the WPT test assertion, this test file can be

+ // removed.

assert_equals(result.headers['user-agent'], navigator.userAgent,

'User-Agent header');

assert_equals(result.append_header_error, 'TypeError',