third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.request-end-to-end.html - Issue 2889153004: Upstream service worker "request" tests to WPT

Unified Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.request-end-to-end.html

Issue 2889153004: Upstream service worker "request" tests to WPT (Closed)

Patch Set: Upstream service worker "request" tests to WPT Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/request-end-to-end-worker.js ('k') | third_party/WebKit/LayoutTests/http/tests/serviceworker/request-body-blob.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.request-end-to-end.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/request-end-to-end.html b/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.request-end-to-end.html

similarity index 83%

rename from third_party/WebKit/LayoutTests/http/tests/serviceworker/request-end-to-end.html

rename to third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.request-end-to-end.html

index 9b7c91645316a523a98e9f0ff0af6c65e2775fd1..bb17ff970e0e5377cd184ef6f979825d4e1627f7 100644

--- a/third_party/WebKit/LayoutTests/http/tests/serviceworker/request-end-to-end.html

+++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium.request-end-to-end.html

@@ -1,4 +1,9 @@

<!DOCTYPE html>

+<!-- This test is prefixed with `chromium.` because the equivalent version

+ available in Web Platform Tests contains additional assertions which Chromium

+ currently fails. This test should be persisted only to preserve test coverage

+ until such time as the upstream version can be made to pass. See

+ https://crbug.com/595993 -->

<title>Service Worker: FetchEvent.request passed to onfetch</title>

@@ -27,8 +32,6 @@ promise_test(t => {

'TypeError.')

assert_equals(result.credentials, 'include', 'request.credentials');

assert_equals(result.redirect, 'manual', 'request.redirect');

- assert_equals(result.headers['user-agent'], navigator.userAgent,

- 'User-Agent header');

falken 2017/05/19 03:46:21 I'd actually rather keep this assert with a // TO

mike3 2017/05/19 16:12:11 Nice thinking!

assert_equals(result.append_header_error, 'TypeError',

'Appending a new header to the request must throw a ' +

'TypeError.')