Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Unified Diff: chrome/browser/resources/settings/internet_page/internet_detail_page.js

Issue 2889073002: Settings: Internet page cleanup (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/internet_page/internet_detail_page.js
diff --git a/chrome/browser/resources/settings/internet_page/internet_detail_page.js b/chrome/browser/resources/settings/internet_page/internet_detail_page.js
index 064757041f3459e284dffa493d3c90f03eb878e0..7e778073317a4d219c7f8999f878d2776e236ba7 100644
--- a/chrome/browser/resources/settings/internet_page/internet_detail_page.js
+++ b/chrome/browser/resources/settings/internet_page/internet_detail_page.js
@@ -131,8 +131,8 @@ Polymer({
ETHERNET: CrOnc.Type.ETHERNET,
TETHER: CrOnc.Type.TETHER,
VPN: CrOnc.Type.VPN,
- WIFI: CrOnc.Type.WI_FI,
- WIMAX: CrOnc.Type.WI_MAX,
+ WI_FI: CrOnc.Type.WI_FI,
+ WI_MAX: CrOnc.Type.WI_MAX,
},
readOnly: true
},
@@ -217,10 +217,9 @@ Polymer({
/** @private */
close_: function() {
- // Delay navigating until the next render frame to allow other subpages to
- // load first.
- setTimeout(function() {
- settings.navigateTo(settings.Route.INTERNET);
+ // Delay navigating to allow other subpages to load first.
+ requestAnimationFrame(function() {
+ settings.navigateToPreviousRoute();
});
},
@@ -312,7 +311,7 @@ Polymer({
/**
* networkingPrivate.getProperties callback.
- * @param {CrOnc.NetworkProperties} properties The network properties.
+ * @param {!CrOnc.NetworkProperties} properties The network properties.
* @private
*/
getPropertiesCallback_: function(properties) {

Powered by Google App Engine
This is Rietveld 408576698